From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Noel Ullreich <n.ullreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve_installer v3] tui: don't abort install if min ram requirement is not met
Date: Thu, 13 Jul 2023 16:06:38 +0200 [thread overview]
Message-ID: <ad97dfa0-393f-e70a-b35e-35d7d4ae0eda@proxmox.com> (raw)
In-Reply-To: <20230710092227.24642-1-n.ullreich@proxmox.com>
Am 10/07/2023 um 11:22 schrieb Noel Ullreich:
> If the minimum requirements are not met, the TUI installer will create a
> popup notifying you that the install might not work and then exits the
> installer.
> While the GUI also creates such a popup, it will not exit the installer.
> This patch adapts the behavior of the GUI: the TUI creates a popup
> warning you that min spec is not met but doesn't abort the install.
>
> Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
> ---
> changes from v1:
> * moved the min ram check into `installer_setup_late`
> * fixed spelling in the subject line
>
> changes from v2:
> * fixed formatting
> * removed unnecessary `installer_setup_late` call
>
> proxmox-tui-installer/src/main.rs | 13 +++++++++++--
> proxmox-tui-installer/src/system.rs | 14 +-------------
> 2 files changed, 12 insertions(+), 15 deletions(-)
>
>
applied, with a context merge conflict resolved and total_memory folded into
the if expression directly, as proposed by Christoph when reviewing v2, as with
his patch for central hvm-support applied previously we now have a owned "state"
available, thanks!
prev parent reply other threads:[~2023-07-13 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 9:22 [pve-devel] " Noel Ullreich
2023-07-10 9:48 ` Christoph Heiss
2023-07-13 14:06 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad97dfa0-393f-e70a-b35e-35d7d4ae0eda@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=n.ullreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox