From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager 1/2] pve6to7: storage content: skip scanning storage if shared
Date: Thu, 8 Jul 2021 09:26:08 +0200 [thread overview]
Message-ID: <ad4e64ef-9789-3d4c-2821-e1c4ca63c309@proxmox.com> (raw)
In-Reply-To: <20210707102250.5478-1-f.ebner@proxmox.com>
On 07.07.21 12:22, Fabian Ebner wrote:
> Shared storages are not scanned for migration either, so they cannot
> be problematic in this context. This could lead to false positives
> where it actually is completely unproblematic:
>
> https://forum.proxmox.com/threads/proxmox-ve-7-0-released.92007/post-401165
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/CLI/pve6to7.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
forgot to reply yesterday, but already applied both patches as IMO the confusion
causing element was way higher than any actual real risk for those unreferenced
volumes. If it seems it would have helped actually then I'd vouch for doing it
on "--full" only and to explicitly note when the warning is not an issue.
prev parent reply other threads:[~2021-07-08 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 10:22 [pve-devel] " Fabian Ebner
2021-07-07 10:22 ` [pve-devel] [PATCH manager 2/2] pve6to7: storage content: ignore misconfigured unreferenced volumes Fabian Ebner
2021-07-08 7:29 ` Fabian Grünbichler
2021-07-08 7:37 ` Thomas Lamprecht
2021-07-08 7:23 ` [pve-devel] [PATCH manager 1/2] pve6to7: storage content: skip scanning storage if shared Fabian Grünbichler
2021-07-08 7:26 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad4e64ef-9789-3d4c-2821-e1c4ca63c309@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox