public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: [pve-devel] qemu + tcmalloc for rbd
Date: Tue, 9 Jan 2024 17:02:28 +0000	[thread overview]
Message-ID: <ac74c5ebc804d276edf8d15c73903c27e3022284.camel@groupe-cyllene.com> (raw)

Hi,

I still have this last year patch pending

https://lists.proxmox.com/pipermail/pve-devel/2023-May/056815.html

to enabled conditionnaly tcmalloc in qemu 

It's still required for performance with librbd with last qemu /lirbd
I get a 30-40% performance boost in iops and latency for small
read/writes.


I would like to have a solution in proxmox repo, instead of maintain it
on my side.


Currently, In production, I compile qemu with tcmalloc at build.

This patch serie, allow to do use LD_PRELOAD +  disable malloc_trim()
call in qemu.

I'm not expert in C (I re-used code from haproxy, which is doing
exactly the same thing with tcmalloc && trim). 
So if somebody can review it, it could be great :)



Another way (maybe safer), is to build 2 binary in same package 
(/usr/bin/kvm-tcmalloc  && /usr/bin/kvm), and give option to user to
choose it.









             reply	other threads:[~2024-01-09 17:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 17:02 DERUMIER, Alexandre [this message]
2024-01-10  9:12 ` Fiona Ebner
2024-01-10  9:38   ` DERUMIER, Alexandre
2024-01-10 14:53     ` Thomas Lamprecht
2024-01-10 10:15   ` Thomas Lamprecht
2024-01-10 18:29     ` DERUMIER, Alexandre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac74c5ebc804d276edf8d15c73903c27e3022284.camel@groupe-cyllene.com \
    --to=alexandre.derumier@groupe-cyllene.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal