From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v3] fix #2788: do not resume vms after backup if they were paused before
Date: Tue, 26 Jan 2021 18:43:28 +0100 [thread overview]
Message-ID: <ac676d1a-5a1c-35bf-c76f-49d2df5e9f2d@proxmox.com> (raw)
In-Reply-To: <20210120123204.11176-1-d.csapak@proxmox.com>
On 20.01.21 13:32, Dominik Csapak wrote:
> by checking if the vm is paused at the beginning and skipping the resume
> now we also skip the qga freeze/thaw (which cannot work if the vm is
> paused)
>
> moved the 'vm_is_paused' sub from the api to PVE/QemuServer.pm so it is
> available everywhere we need it.
>
> since a suspend backup would pause the vm anyway, we can skip that step
> also
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes to v2:
> * actually include code changes (git add is not optional), sry for the noise
>
> PVE/API2/Qemu.pm | 14 ++------------
> PVE/QemuServer.pm | 10 ++++++++++
> PVE/VZDump/QemuServer.pm | 11 +++++++++--
> 3 files changed, 21 insertions(+), 14 deletions(-)
>
>
applied, with Fabi's T-b, thanks!
Not sure if it'd be really worth it to do the backup-init lock proposed in
a thread reply here though..
prev parent reply other threads:[~2021-01-26 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 12:32 [pve-devel] " Dominik Csapak
2021-01-20 14:15 ` Fabian Ebner
2021-01-21 9:26 ` Dominik Csapak
2021-01-21 10:41 ` Fabian Ebner
2021-01-26 17:43 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac676d1a-5a1c-35bf-c76f-49d2df5e9f2d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox