From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-firewall] firewall: properly cleanup tables when firewall is inactive
Date: Tue, 23 Apr 2024 16:32:18 +0200 [thread overview]
Message-ID: <ac399fd3-3142-452a-a717-cd43f7269f9d@proxmox.com> (raw)
In-Reply-To: <20240423092139.94402-1-s.hanreich@proxmox.com>
Am 23/04/2024 um 11:21 schrieb Stefan Hanreich:
> When executing multiple nft commands they are transactional, either
> all get applied or none. When only the host or guest firewall is
> active, only one table exists and this causes the delete commands to
> fail. To fix this we need to send the delete commands separately.
>
> It might make sense to support running multiple separate batches in
> the NftClient in the future in order to avoid having to call nft
> twice.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> proxmox-firewall/src/bin/proxmox-firewall.rs | 9 +++++----
> proxmox-firewall/src/firewall.rs | 10 +++++-----
> 2 files changed, 10 insertions(+), 9 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-23 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 9:21 [pve-devel] " Stefan Hanreich
2024-04-23 14:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac399fd3-3142-452a-a717-cd43f7269f9d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox