public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd
Date: Thu, 16 Mar 2023 06:53:47 +0000	[thread overview]
Message-ID: <ac1e65082c2fe25e104c5c80addc64c33abfa339.camel@groupe-cyllene.com> (raw)
In-Reply-To: <c83e3360-b157-3374-189e-d01504ae0788@proxmox.com>

Hi,



> > > +++ b/debian/pve-cluster.postinst
> > > @@ -0,0 +1,6 @@
> > > +#!/bin/bash
> > > +
> > > +RRD_DB="/var/lib/rrdcached/db/pve2-node/`hostname`"
> > > +if [ -f $RRD_DB ] && [ `rrdtool info $RRD_DB | grep -q arcsize`
> > > ]; then
> > > +        rrdtool tune $RRD_DB 'DS:arcsize:GAUGE:120:0:U'
> > > +fi
> > 
> > 

I totally miss it, but since rrdtool 1.5, indeed, it's possible to add
new datasource in existing rrd with "rrdtool tune" like in your patch
:)


It was not possible in the past, that's why a new rrd was needed :)


  reply	other threads:[~2023-03-16  6:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 11:29 [pve-devel] [RFC ] fix #1454 - include ZFS ARC in memory usage Matthias Heiserer
2023-01-25 11:29 ` [pve-devel] [RFC OPTIONAL pve-cluster 1/1] add arcsize to rrd Matthias Heiserer
2023-03-15 11:10   ` Dominik Csapak
2023-03-15 11:51     ` Matthias Heiserer
2023-03-16  6:53       ` DERUMIER, Alexandre [this message]
2023-03-17 13:17       ` Matthias Heiserer
2023-03-15 12:29     ` DERUMIER, Alexandre
2023-01-25 11:29 ` [pve-devel] [RFC common] procfstools: add arcsize to meminfo Matthias Heiserer
2023-01-25 11:29 ` [pve-devel] [PATCH manager 1/4] node/status: return arc size Matthias Heiserer
2023-01-25 11:29 ` [pve-devel] [RFC widget-toolkit] ui: add InfoMultiWidget, to be used for RAM Matthias Heiserer
2023-03-15 11:10   ` Dominik Csapak
2023-03-15 11:14   ` Dominik Csapak
2023-01-25 11:29 ` [pve-devel] [PATCH manager 2/4] store arcsize in rrd Matthias Heiserer
2023-01-25 11:29 ` [pve-devel] [PATCH manager 3/4] ui: node summary: show arc in rrd graph Matthias Heiserer
2023-01-25 11:29 ` [pve-devel] [PATCH manager 4/4] ui: node summary: show arc in RAM usage progress bar Matthias Heiserer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac1e65082c2fe25e104c5c80addc64c33abfa339.camel@groupe-cyllene.com \
    --to=alexandre.derumier@groupe-cyllene.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal