From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines
Date: Fri, 19 Jan 2024 11:59:53 +0100 [thread overview]
Message-ID: <ac021341-a61c-4491-b198-77901ec7be01@proxmox.com> (raw)
In-Reply-To: <20240118111147.131727-1-f.weber@proxmox.com>
Am 18.01.24 um 12:11 schrieb Friedrich Weber:
> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
> index 4b951e7..5377823 100644
> --- a/src/PVE/Storage/LVMPlugin.pm
> +++ b/src/PVE/Storage/LVMPlugin.pm
> @@ -130,6 +130,11 @@ sub lvm_vgs {
>
> my ($name, $size, $free, $lvcount, $pvname, $pvsize, $pvfree) = split (':', $line);
>
> + if (!defined($size) || !defined($free) || !defined($lvcount)) {
> + warn "unexpected output from vgs: $line\n";
> + return;
> + }
> +
Nit: maybe quote 'vgs' and/or say "command 'vgs'"?
Please use log_warn() from PVE::RESTEnvironment for new warnings, so
they also show up in task logs.
next prev parent reply other threads:[~2024-01-19 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 11:11 Friedrich Weber
2024-01-19 10:59 ` Fiona Ebner [this message]
2024-01-19 11:31 ` Fiona Ebner
2024-01-23 10:01 ` Friedrich Weber
2024-01-31 11:55 ` Friedrich Weber
2024-02-01 9:20 ` Fiona Ebner
2024-02-01 9:30 ` Fiona Ebner
2024-02-02 16:27 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac021341-a61c-4491-b198-77901ec7be01@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox