public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH cluster 0/3] logging improvements
Date: Thu, 22 Apr 2021 21:45:52 +0200	[thread overview]
Message-ID: <abe32a92-cb53-39bc-7b0b-8d28d124a934@proxmox.com> (raw)
In-Reply-To: <20201001085326.3815261-1-f.gruenbichler@proxmox.com>

On 01.10.20 10:53, Fabian Grünbichler wrote:
> noticed while debugging the (as it turns out) missing lock issue that
> qb_log is not thread-safe by default, this patch series switches to
> threaded, non-blocking logging.
> 
> Fabian Grünbichler (3):
>   pmxcfs: switch log domain to enum
>   pmxcfs: set log domain in more places
>   pmxcfs: enable QB log thread
> 
>  data/src/cfs-utils.h      | 36 ++++++++++++++++++++++++++++++++----
>  data/src/dfsm.h           |  6 +++---
>  data/src/loop.h           |  2 +-
>  data/src/cfs-plug-func.c  |  2 ++
>  data/src/cfs-plug-link.c  |  2 ++
>  data/src/cfs-plug-memdb.c |  2 ++
>  data/src/cfs-plug.c       |  2 ++
>  data/src/cfs-utils.c      | 16 ++++++++--------
>  data/src/confdb.c         |  3 ++-
>  data/src/database.c       |  1 +
>  data/src/dcdb.c           |  3 ++-
>  data/src/dfsm.c           | 18 +++++++++++-------
>  data/src/logger.c         |  2 ++
>  data/src/loop.c           | 11 ++++++-----
>  data/src/memdb.c          |  2 ++
>  data/src/pmxcfs.c         | 21 ++++++++++++---------
>  data/src/quorum.c         |  3 ++-
>  data/src/server.c         |  1 +
>  data/src/status.c         |  3 ++-
>  19 files changed, 95 insertions(+), 41 deletions(-)
> 

would need a rebase if we still want this




      parent reply	other threads:[~2021-04-22 19:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01  8:53 Fabian Grünbichler
2020-10-01  8:53 ` [pve-devel] [RFC cluster 1/3] pmxcfs: switch log domain to enum Fabian Grünbichler
2020-10-01  8:53 ` [pve-devel] [PATCH cluster 2/3] pmxcfs: set log domain in more places Fabian Grünbichler
2020-10-01  8:53 ` [pve-devel] [PATCH cluster 3/3] pmxcfs: enable QB log thread Fabian Grünbichler
2021-04-22 19:45 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abe32a92-cb53-39bc-7b0b-8d28d124a934@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal