From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Shan Shaji <s.shaji@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] widgets: migrate from ButtonBar to OverflowBar
Date: Fri, 2 May 2025 09:24:28 +0200 [thread overview]
Message-ID: <aba3d634-12c5-4945-8daf-2e1a33b139bb@proxmox.com> (raw)
In-Reply-To: <20250424162519.259066-1-s.shaji@proxmox.com>
On 4/24/25 18:25, Shan Shaji wrote:
> The `ButtonBar` widget has been deprecated as of Flutter
> v3.21.0-10.0.pre. This patch replaces instance of `ButtonBar`
> with `OverflowBar`.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
Quickly tested this by comparing the behavior of the previously
implemented ButtonBar and the new OverflowBar and also checking for any
unwanted visual changes. The bar behaves and looks the same, clickable
elements still work as expected.
I also had a look at the Flutter documentation[0] for migrating from
ButtonBar to OverflowBar. The recommended changes to keep the behavior
identical to the ButtonBar were made in this patch, so everything looks
good to me.
Please consider this
Tested-By: Michael Köppl <m.koeppl@proxmox.com>
Reviewed-By: Michael Köppl <m.koeppl@proxmox.com>
[0] https://docs.flutter.dev/release/breaking-changes/deprecate-buttonbar
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-02 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 16:25 Shan Shaji
2025-05-02 7:24 ` Michael Köppl [this message]
2025-05-07 7:50 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aba3d634-12c5-4945-8daf-2e1a33b139bb@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal