From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] fix #6815: ui: resource tree: update tag colors properly
Date: Fri, 10 Oct 2025 09:30:39 +0200 [thread overview]
Message-ID: <ab8a3d1e-dd73-42ed-bec0-b142bbd79ceb@proxmox.com> (raw)
In-Reply-To: <20251010072802.798062-1-d.csapak@proxmox.com>
forgot to write, this should be backported to stable-8 too, should be
cleanly cherry-pickable
On 10/10/25 9:28 AM, Dominik Csapak wrote:
> In commit:
> e19de81f (ui: resource tree: fix change detection)
> the change detection for resource tree nodes was fixed so that it did
> not update on every refresh anymore.
>
> This now also means that when the ui options are loaded (which contains
> the tag color overrides) we now have to correctly update nodes which
> contains tags, otherwise the standard colors will be shown.
>
> There is already an event handler for the 'loadedUiOptions', so simply
> adapt it to also update the tree nodes that contains tags.
>
> Fixes: e19de81f (ui: resource tree: fix change detection)
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/tree/ResourceTree.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
> index 315976e0..e83ccfc8 100644
> --- a/www/manager6/tree/ResourceTree.js
> +++ b/www/manager6/tree/ResourceTree.js
> @@ -605,7 +605,7 @@ Ext.define('PVE.tree.ResourceTree', {
> me.mon(Ext.GlobalEvents, 'loadedUiOptions', () => {
> me.store.getRootNode().cascadeBy({
> before: function (node) {
> - if (node.data.groupbyid) {
> + if (node.data.groupbyid || node.data.tags) {
> node.beginEdit();
> let info = node.data;
> me.setIconCls(info);
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-10 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 7:27 Dominik Csapak
2025-10-10 7:30 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab8a3d1e-dd73-42ed-bec0-b142bbd79ceb@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox