public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	Stefan Hrdlicka <s.hrdlicka@proxmox.com>
Subject: Re: [pve-devel] [PATCH V6 pve-manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs
Date: Tue, 13 Dec 2022 13:12:58 +0100	[thread overview]
Message-ID: <ab4e2722-fcae-5d86-d7bc-30525b200ac3@proxmox.com> (raw)
In-Reply-To: <5ff01d81-cb4b-fea1-8810-60eb8522f585@proxmox.com>

Am 21/10/2022 um 11:24 schrieb Dominik Csapak:
> All in all LGTM, one small UX thing that i am not sure if we can improve without
> making it way more complicated:
> 
> We now preselect the current node and leave the restriction out.
> We then restrict when the node changes, but remove the restriction
> again when we select the current node.

IIUC, you mean that the node selector implies that it's restricted to the node that one
has loaded the web-interface with, even if that's then not the case.

As if that's the case then yes, that'd seem like confusing UX.

> 
> Maybe we want to just leave the restriction out when we load
> the panel up, but always restrict when a user sets the node?
> (as in, if i manually select the current node again, restrict
> it?)

And here you propose that we keep the empty value, and thus the "All (No restrictions)"
displayed on edit window creation, and if any node is actually selected by the user then we
always restrict it to that (just to ensure IIUC)?


If IIUC, then yes, while mabye not the best (as its an odd "problem") it might be the
better way.

> 
> not sure if we'd want that or leave it like it is (or something else entirely?)
> @Thomas do you have any thoughts about that?






      reply	other threads:[~2022-12-13 12:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30 12:38 Stefan Hrdlicka
2022-09-30 12:38 ` [pve-devel] [PATCH V6 pve-manager 1/2] fix #2822: add iscsi, lvm, lvmthin & zfs storage for all cluster nodes Stefan Hrdlicka
2022-09-30 12:38 ` [pve-devel] [PATCH V6 pve-manager 2/2] cleanup: "var" to "let", fix some indentation in related files Stefan Hrdlicka
2022-10-21  9:24 ` [pve-devel] [PATCH V6 pve-manager 0/2] fix #2822: add iscsi, lvm, lvmthin & zfs Dominik Csapak
2022-12-13 12:12   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab4e2722-fcae-5d86-d7bc-30525b200ac3@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hrdlicka@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal