From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Severen Redwood <severen.redwood@sitehost.co.nz>,
pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server] api: record VM ID as used after a virtual machine is destroyed
Date: Thu, 26 Sep 2024 19:53:03 +0200 [thread overview]
Message-ID: <aa647cfc-14e8-4bb5-b5e1-f3a8dad58070@proxmox.com> (raw)
In-Reply-To: <20240926135516.117065-5-severen.redwood@sitehost.co.nz>
Am 26/09/2024 um 15:52 schrieb Severen Redwood:
> After a virtual machine is destroyed, record that its ID has been used
> via the `PVE::UsedVmidList` module so that the `/cluster/nextids`
> endpoint can later optionally avoid suggesting previously used IDs.
>
> Co-authored-by: Daniel Krambrock <krambrock@hrz.uni-marburg.de>
> Signed-off-by: Severen Redwood <severen.redwood@sitehost.co.nz>
> ---
> PVE/API2/Qemu.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index d25a79fe..67a6191f 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -2340,6 +2340,7 @@ __PACKAGE__->register_method({
> });
> };
>
> + PVE::UsedVmidList::add_vmid($vmid);
same here, you write "after a virtual machine is destroyed", but this is quite
a bit before that as the worker might need quite a bit of time to finish, and
that can even fail.
While it's not really causing a issue with recording the VMID as reserved,
that should be evaluated explicitly and mentioned in the commit message.
> return $rpcenv->fork_worker('qmdestroy', $vmid, $authuser, $realcmd);
> }});
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-09-26 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240926135516.117065-1-severen.redwood@sitehost.co.nz>
2024-09-26 13:52 ` [pve-devel] [PATCH manager 1/2] close #4369: api: optionally only suggest unique IDs Severen Redwood via pve-devel
2024-09-26 15:34 ` Dietmar Maurer
2024-09-29 13:47 ` DERUMIER, Alexandre via pve-devel
2024-09-30 1:58 ` Severen Redwood via pve-devel
[not found] ` <ce6ov3znxweopubjnsw35m5aiboohi2r5yza76brljruxyhbmx@wbnvnhtmvq4v>
2024-09-30 7:50 ` Dietmar Maurer
2024-09-30 8:06 ` DERUMIER, Alexandre via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH manager 2/2] close #4369: ui: add datacenter option for unique VM/CT IDs Severen Redwood via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH container] api: record CT ID as used after a container is destroyed Severen Redwood via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH qemu-server] api: record VM ID as used after a virtual machine " Severen Redwood via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH cluster 1/2] cluster files: add used_vmids.list Severen Redwood via pve-devel
2024-09-26 13:52 ` [pve-devel] [PATCH cluster 2/2] datacenter config: add unique-next-id to schema Severen Redwood via pve-devel
[not found] ` <20240926135516.117065-4-severen.redwood@sitehost.co.nz>
2024-09-26 17:48 ` [pve-devel] [PATCH container] api: record CT ID as used after a container is destroyed Thomas Lamprecht
2024-09-30 0:24 ` Severen Redwood via pve-devel
[not found] ` <20240926135516.117065-5-severen.redwood@sitehost.co.nz>
2024-09-26 17:53 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa647cfc-14e8-4bb5-b5e1-f3a8dad58070@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=severen.redwood@sitehost.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox