From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Dominic Jäger" <d.jaeger@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] vzdump mail: Refactor text part
Date: Tue, 17 Nov 2020 14:27:11 +0100 [thread overview]
Message-ID: <aa419a85-b265-6697-1de3-301a89ca95c0@proxmox.com> (raw)
In-Reply-To: <20201117104652.256046-1-d.jaeger@proxmox.com>
On 17.11.20 11:46, Dominic Jäger wrote:
> Less lines exeeding the character limit, less nesting, less duplicate code,
> more readable sprintf arguments.
>
> Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
> Middle ground sounds good to me :) And separate lines for arguments look nice.
> PVE/VZDump.pm | 36 +++++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 17 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-11-17 13:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 10:46 [pve-devel] " Dominic Jäger
2020-11-17 13:27 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa419a85-b265-6697-1de3-301a89ca95c0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.jaeger@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox