From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [RFC/PATCH qemu] fix #3084: fall back to open-iscsi initiatorname
Date: Sat, 6 Feb 2021 15:10:36 +0100 [thread overview]
Message-ID: <a9e933dd-1bbf-e7dc-8e2a-af0d62e8255f@proxmox.com> (raw)
In-Reply-To: <20201117113836.16895-1-f.ebner@proxmox.com>
On 17.11.20 12:38, Fabian Ebner wrote:
> Fixes vma restore when the target is an iSCSI storage which expects that
> initiatorname. Also avoids the need to always explicitly set the initiatorname
> in PVE code, thus fixing moving efidisks from and to such iSCSI storages.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> The obvious alternative is to add the option in vma itself. But I'd like to
> hear some opinions about this approach first. One downside is that the old
> default behavior (i.e. using iqn.2008-11.org.linux-kvmXXX) is overwritten as
> long as an initiatorname can be read from /etc/iscsi/initiatorname.iscsi, but
> as PVE only reads the initiatorname from there, relying on that behavior seems
> to be incompatible with our tooling anyways.
>
> ...all-back-to-open-iscsi-initiatorname.patch | 71 +++++++++++++++++++
> debian/patches/series | 1 +
> 2 files changed, 72 insertions(+)
> create mode 100644 debian/patches/pve/0057-PVE-fall-back-to-open-iscsi-initiatorname.patch
>
>
applied, thanks!
Had to resolve a trivial merge-conflict as there was a 0057 patch applied in
between, so this is now 0058.
prev parent reply other threads:[~2021-02-06 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 11:38 [pve-devel] " Fabian Ebner
2020-11-19 10:58 ` Dominik Csapak
2021-02-06 14:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9e933dd-1bbf-e7dc-8e2a-af0d62e8255f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox