public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Mira Limbeck <m.limbeck@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] fix #4963: firewall: fix editing firewall rules using cidrs
Date: Tue, 16 Jan 2024 15:31:34 +0100	[thread overview]
Message-ID: <a9d747b0-a3f2-49be-a348-b06cf21c07b7@proxmox.com> (raw)
In-Reply-To: <d4fafa75-8388-47bd-af26-f71f1825779a@proxmox.com>



On 1/16/24 11:33, Mira Limbeck wrote:
> This removes the error reported in the bug tracker, but new changes to
> the IP are not recognized.
> E.g.:
> original IP range: 10.0.0.0/8
> new IP range: 192.168.0.0/24
> 
> The `ok` button is still disabled unless you change anything else,
> change to an IPset or alias, or remove the entire IP entry via the `x`
> and type it again.

Thanks for the report, didn't notice that.

Sent a v2 here:
https://lists.proxmox.com/pipermail/pve-devel/2024-January/061388.html




      reply	other threads:[~2024-01-16 14:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 16:28 Stefan Hanreich
2024-01-16 10:33 ` Mira Limbeck
2024-01-16 14:31   ` Stefan Hanreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9d747b0-a3f2-49be-a348-b06cf21c07b7@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal