From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] add 'auto' mode for noVNC scaling
Date: Thu, 13 Jan 2022 13:03:45 +0100 [thread overview]
Message-ID: <a9966e60-0cb8-1dda-3d0d-7a51a45009a9@proxmox.com> (raw)
In-Reply-To: <20220113075633.473258-1-d.csapak@proxmox.com>
On 13.01.22 08:56, Dominik Csapak wrote:
> in commit
> 69c6561f820b4fdb5625ead767889155db9f1539 ("ui: fix novnc scaling radio button")
>
> we always set to 'scale' when no value was set, but a non-set value
> actually had a different behaviour:
>
> in the embedded console it was set to 'scale', but in the pop-up it was
> set to 'off'.
>
> to restore this behaviour, introduce an option 'auto' which unsets the
> 'novnc-scaling' setting
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/window/Settings.js | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-01-13 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 7:56 [pve-devel] " Dominik Csapak
2022-01-13 12:03 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9966e60-0cb8-1dda-3d0d-7a51a45009a9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox