public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH installer 0/3] memorize keyboard layout and run setupcon in background
Date: Thu, 10 Dec 2020 20:07:44 +0100	[thread overview]
Message-ID: <a9576034-3cc0-06bf-e8de-0dc257830d6a@proxmox.com> (raw)
In-Reply-To: <20201110141530.30904-1-s.ivanov@proxmox.com>

On 10.11.20 15:15, Stoiko Ivanov wrote:
> This patchset addresses the issue found by Oguz with setupcon slowing down the
> GUI.
> 
> After some discussion off-list with Thomas and Oguz 2 thinks were considered
> worth improving:
> * memorize the chosen keyboard layout and don't jump back to the one defined
> by the country - when using the Previous/Next buttons
> * still set the keymap of the installer system, but do it in the background
> 
> I tested the patches locally and think they work as they should (but then again
> the possible combinations of changed country/changed keymap/freshly drawn
> window confused me a bit - so would be grateful for some testing)
> 
> 
> Stoiko Ivanov (3):
>   memorize keyboard layout selection
>   add run_in_background
>   set the keymap on the installer console
> 
>  proxinstall | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 51 insertions(+), 1 deletion(-)
> 



applied series, thanks!




      parent reply	other threads:[~2020-12-10 19:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 14:15 [pve-devel] " Stoiko Ivanov
2020-11-10 14:15 ` [pve-devel] [PATCH installer 1/3] memorize keyboard layout selection Stoiko Ivanov
2020-11-10 14:15 ` [pve-devel] [PATCH installer 2/3] add run_in_background Stoiko Ivanov
2020-11-10 14:15 ` [pve-devel] [PATCH installer 3/3] set the keymap on the installer console Stoiko Ivanov
2020-11-10 14:33 ` [pve-devel] [PATCH installer 0/3] memorize keyboard layout and run setupcon in background Oguz Bektas
2020-12-10 19:07 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9576034-3cc0-06bf-e8de-0dc257830d6a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal