public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: aderumier@odiso.com
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	 pbs-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH 00/11] live-restore for PBS snapshots
Date: Mon, 11 Jan 2021 16:50:14 +0100	[thread overview]
Message-ID: <a91ee7b1e8094581fefa180f02b40a47f14eb722.camel@odiso.com> (raw)
In-Reply-To: <20210111111409.32385-1-s.reiter@proxmox.com>

Hi,
that's great !

I'm not sure it's related, but do you have any plan to add support to
restore/extract files from the vm filesystem directly ? 
if we could make some kind of qemu-nbd + mount loop of the backup
volume for example.


This is the main blocking feature for me, instead using my rbd
import/export for backups.

Regards,

Alexandre

Le lundi 11 janvier 2021 à 12:13 +0100, Stefan Reiter a écrit :
> "live-restore" allows starting a VM immediately from a backup
> snapshot, no
> waiting for a long restore process. This is made possible with QEMU
> backing
> images, i.e. data is read from the backup which is attached to the VM
> as a
> drive, but new data is written to the destination, while a background
> process
> ('block-stream') copies over data in a linear fashion as well.
> 
> QEMU backing images are normally only supported for qcow2 images, but
> since the
> destination always starts out empty, we can use a dirty bitmap to
> achieve the
> same effect - this is implemented as the 'alloc-track' driver in the
> 'qemu' part
> of the series.
> 
> The Rust part of the equation is adjusted to provide (quiet a lot)
> more caching,
> as mixing random read/write from the guest with the linear reads from
> the
> background process (both of which may use read sizes smaller or
> bigger than a
> single chunk) would thrash performance without large buffers.
> 
> I've marked the feature as 'experimental' in the GUI for now, as I'm
> sure there
> are a lot of edge cases I've missed to test, and there's also the
> possibility of
> data loss, since anything the VM writes during the restore is removed
> if the
> restore fails.
> 
> 
> qemu: Stefan Reiter (3):
>   PVE: explicitly add libuuid as linking dependency
>   PVE: block/pbs: fast-path reads without allocation if possible
>   block: add alloc-track driver
> 
>  Makefile.objs       |   2 +
>  block/Makefile.objs |   1 +
>  block/alloc-track.c | 319
> ++++++++++++++++++++++++++++++++++++++++++++
>  block/pbs.c         |  17 ++-
>  4 files changed, 336 insertions(+), 3 deletions(-)
>  create mode 100644 block/alloc-track.c
> 
> proxmox-backup: Stefan Reiter (1):
>   RemoteChunkReader: add LRU cached variant
> 
>  src/bin/proxmox_backup_client/mount.rs |  4 +-
>  src/client/remote_chunk_reader.rs      | 77 ++++++++++++++++++++----
> --
>  2 files changed, 62 insertions(+), 19 deletions(-)
> 
> proxmox-backup-qemu: Stefan Reiter (1):
>   access: use bigger cache and LRU chunk reader
> 
>  src/restore.rs | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> qemu-server: Stefan Reiter (5):
>   make qemu_drive_mirror_monitor more generic
>   cfg2cmd: allow PBS snapshots as backing files for drives
>   enable live-restore for PBS
>   extract register_qmeventd_handle to QemuServer.pm
>   live-restore: register qmeventd handle
> 
>  PVE/API2/Qemu.pm         |  15 ++-
>  PVE/QemuServer.pm        | 263 ++++++++++++++++++++++++++++++++-----
> --
>  PVE/VZDump/QemuServer.pm |  32 +----
>  3 files changed, 233 insertions(+), 77 deletions(-)
> 
> manager: Stefan Reiter (1):
>   ui: restore: add live-restore checkbox
> 
>  www/manager6/grid/BackupView.js    |  8 +++++--
>  www/manager6/storage/BackupView.js |  7 ++++--
>  www/manager6/window/Restore.js     | 38
> +++++++++++++++++++++++++++++-
>  3 files changed, 48 insertions(+), 5 deletions(-)
> 





  parent reply	other threads:[~2021-01-11 15:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 11:13 Stefan Reiter
2021-01-11 11:13 ` [pve-devel] [PATCH qemu 01/11] PVE: explicitly add libuuid as linking dependency Stefan Reiter
2021-01-12 12:04   ` [pve-devel] [pbs-devel] " Thomas Lamprecht
2021-01-18 10:27     ` [pve-devel] [PATCH pve-qemu] explicitly specify " Stefan Reiter
2021-01-27  8:29       ` Stefan Reiter
2021-01-11 11:14 ` [pve-devel] [PATCH qemu 02/11] PVE: block/pbs: fast-path reads without allocation if possible Stefan Reiter
2021-01-12  9:29   ` Wolfgang Bumiller
2021-01-11 11:14 ` [pve-devel] [PATCH qemu 03/11] block: add alloc-track driver Stefan Reiter
2021-01-12 10:54   ` Wolfgang Bumiller
2021-01-12 11:29     ` Stefan Reiter
2021-01-12 13:42       ` Wolfgang Bumiller
2021-01-11 11:14 ` [pve-devel] [PATCH proxmox-backup 04/11] RemoteChunkReader: add LRU cached variant Stefan Reiter
2021-01-11 11:14 ` [pve-devel] [PATCH proxmox-backup-qemu 05/11] access: use bigger cache and LRU chunk reader Stefan Reiter
2021-01-11 11:14 ` [pve-devel] [PATCH qemu-server 06/11] make qemu_drive_mirror_monitor more generic Stefan Reiter
2021-01-12 13:19   ` Wolfgang Bumiller
2021-01-11 11:14 ` [pve-devel] [PATCH qemu-server 07/11] cfg2cmd: allow PBS snapshots as backing files for drives Stefan Reiter
2021-01-28 16:25   ` Thomas Lamprecht
2021-01-11 11:14 ` [pve-devel] [PATCH qemu-server 08/11] enable live-restore for PBS Stefan Reiter
2021-01-11 11:14 ` [pve-devel] [PATCH qemu-server 09/11] extract register_qmeventd_handle to QemuServer.pm Stefan Reiter
2021-01-11 11:14 ` [pve-devel] [PATCH qemu-server 10/11] live-restore: register qmeventd handle Stefan Reiter
2021-01-11 11:14 ` [pve-devel] [PATCH manager 11/11] ui: restore: add live-restore checkbox Stefan Reiter
2021-01-11 15:50 ` aderumier [this message]
2021-01-11 16:42   ` [pve-devel] [PATCH 00/11] live-restore for PBS snapshots Stefan Reiter
2021-01-12  9:10     ` aderumier
2021-01-12 10:31   ` [pve-devel] [pbs-devel] " Thomas Lamprecht
2021-01-12 11:23     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a91ee7b1e8094581fefa180f02b40a47f14eb722.camel@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal