From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH storage] fix #5071: zfs over iscsi: iet, lio: use /dev/zvol as a base path if it exists
Date: Tue, 27 May 2025 13:59:15 +0200 [thread overview]
Message-ID: <a9125c72-b057-45e8-8bc9-f29542deb95a@proxmox.com> (raw)
In-Reply-To: <20250527105913.39464-1-f.ebner@proxmox.com>
Am 27.05.25 um 12:59 schrieb Fiona Ebner:
> sub get_base {
> - return '/dev';
> + if (!$base_dir) {
> + $base_dir = -e '/dev/zvol' ? '/dev/zvol' : '/dev';
> + }
> + return $base_dir;
> }
>
Of course, this is completely wrong, because the path would need to be
checked on the remote system. I'll also go for the cleaner approach with
using a storage configuration property while at it.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-05-27 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 10:59 Fiona Ebner
2025-05-27 11:59 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9125c72-b057-45e8-8bc9-f29542deb95a@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal