From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH http-server] fix #3724: disable TLS renegotiation
Date: Tue, 16 Nov 2021 07:34:57 +0100 [thread overview]
Message-ID: <a90044f3-7f30-224c-ef78-24e9c1b0e759@proxmox.com> (raw)
In-Reply-To: <20211115205043.23286-1-s.ivanov@proxmox.com>
On 15.11.21 21:50, Stoiko Ivanov wrote:
> The issue is probably not critical and best addressed by not running
> the perl API servers in an exposed environment or when this needs to
> be done by installing a reverse proxy in front of them.
>
> The DOS potential of the perl daemons is limited more by the limited
> number of parallel workers (and the memory constraints of starting
> more of them), than by the CPU cycles wasted on TLS renegotiation.
>
> Still disabling TLS renegotiation should show very little downside:
> * it was removed in TLS 1.3 for security reasons
> * it was the way nginx addressed this issue [1].
> * we do not use client certificate authentication
>
> Tested by running `openssl s_client -no_tls1_3 -connect 192.0.2.1:8006`
> and issuing a `HEAD / HTTP/1.1\nR\n`
> with and without the patch.
>
> [1] 70bd187c4c386d82d6e4d180e0db84f361d1be02 at
> https://github.com/nginx/nginx (although that code adapted to
> the various changes in openssl API over the years)
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PVE/APIServer/AnyEvent.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-11-16 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 20:50 [pve-devel] " Stoiko Ivanov
2021-11-16 6:34 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a90044f3-7f30-224c-ef78-24e9c1b0e759@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox