* [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k
@ 2024-01-29 14:42 Aaron Lauterer
2024-01-29 14:51 ` Fiona Ebner
2024-02-01 12:45 ` [pve-devel] applied: " Fiona Ebner
0 siblings, 2 replies; 4+ messages in thread
From: Aaron Lauterer @ 2024-01-29 14:42 UTC (permalink / raw)
To: pve-devel
to reflect current ZFS defaults.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
unless I have missed it, we currently still show the old default as
placeholder
www/manager6/storage/ZFSPoolEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/storage/ZFSPoolEdit.js b/www/manager6/storage/ZFSPoolEdit.js
index b66d131a..a0141ba3 100644
--- a/www/manager6/storage/ZFSPoolEdit.js
+++ b/www/manager6/storage/ZFSPoolEdit.js
@@ -103,7 +103,7 @@ Ext.define('PVE.storage.ZFSPoolInputPanel', {
{
xtype: 'textfield',
name: 'blocksize',
- emptyText: '8k',
+ emptyText: '16k',
fieldLabel: gettext('Block Size'),
allowBlank: true,
},
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k
2024-01-29 14:42 [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k Aaron Lauterer
@ 2024-01-29 14:51 ` Fiona Ebner
2024-02-01 12:44 ` Fiona Ebner
2024-02-01 12:45 ` [pve-devel] applied: " Fiona Ebner
1 sibling, 1 reply; 4+ messages in thread
From: Fiona Ebner @ 2024-01-29 14:51 UTC (permalink / raw)
To: Proxmox VE development discussion, Aaron Lauterer
Am 29.01.24 um 15:42 schrieb Aaron Lauterer:
> to reflect current ZFS defaults.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> unless I have missed it, we currently still show the old default as
> placeholder
>
> www/manager6/storage/ZFSPoolEdit.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/storage/ZFSPoolEdit.js b/www/manager6/storage/ZFSPoolEdit.js
> index b66d131a..a0141ba3 100644
> --- a/www/manager6/storage/ZFSPoolEdit.js
> +++ b/www/manager6/storage/ZFSPoolEdit.js
> @@ -103,7 +103,7 @@ Ext.define('PVE.storage.ZFSPoolInputPanel', {
> {
> xtype: 'textfield',
> name: 'blocksize',
> - emptyText: '8k',
> + emptyText: '16k',
> fieldLabel: gettext('Block Size'),
> allowBlank: true,
> },
Well, both values are (potentially) wrong, because it depends on the
setting the pool was created with. So maybe "use setting from zpool" or
similar? Orthogonal to the patch, but the option also misses proper
validation in frontend and backend.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k
2024-01-29 14:51 ` Fiona Ebner
@ 2024-02-01 12:44 ` Fiona Ebner
0 siblings, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2024-02-01 12:44 UTC (permalink / raw)
To: Proxmox VE development discussion, Aaron Lauterer
Am 29.01.24 um 15:51 schrieb Fiona Ebner:
>
> Well, both values are (potentially) wrong, because it depends on the
> setting the pool was created with. So maybe "use setting from zpool" or
> similar?
As Aaron told me off-list, this is wrong. There is no pool-wide setting.
Even on a pool created before ZFS 2.2, new zvols will have 16k default
after upgrade.
> Orthogonal to the patch, but the option also misses proper
> validation in frontend and backend.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k
2024-01-29 14:42 [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k Aaron Lauterer
2024-01-29 14:51 ` Fiona Ebner
@ 2024-02-01 12:45 ` Fiona Ebner
1 sibling, 0 replies; 4+ messages in thread
From: Fiona Ebner @ 2024-02-01 12:45 UTC (permalink / raw)
To: Proxmox VE development discussion, Aaron Lauterer
Am 29.01.24 um 15:42 schrieb Aaron Lauterer:
> to reflect current ZFS defaults.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-01 12:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-29 14:42 [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k Aaron Lauterer
2024-01-29 14:51 ` Fiona Ebner
2024-02-01 12:44 ` Fiona Ebner
2024-02-01 12:45 ` [pve-devel] applied: " Fiona Ebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox