From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: storage: zfs: set blocksize placeholder to 16k
Date: Thu, 1 Feb 2024 13:44:41 +0100 [thread overview]
Message-ID: <a8e21558-a357-4ef0-a94b-b308a237ecdc@proxmox.com> (raw)
In-Reply-To: <3179fba1-e37c-4053-8f66-776fda58c89f@proxmox.com>
Am 29.01.24 um 15:51 schrieb Fiona Ebner:
>
> Well, both values are (potentially) wrong, because it depends on the
> setting the pool was created with. So maybe "use setting from zpool" or
> similar?
As Aaron told me off-list, this is wrong. There is no pool-wide setting.
Even on a pool created before ZFS 2.2, new zvols will have 16k default
after upgrade.
> Orthogonal to the patch, but the option also misses proper
> validation in frontend and backend.
next prev parent reply other threads:[~2024-02-01 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 14:42 Aaron Lauterer
2024-01-29 14:51 ` Fiona Ebner
2024-02-01 12:44 ` Fiona Ebner [this message]
2024-02-01 12:45 ` [pve-devel] applied: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8e21558-a357-4ef0-a94b-b308a237ecdc@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox