public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alwin Antreich <a.antreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2 0/8] ceph: allow pools settings to be changed
Date: Tue, 24 Nov 2020 14:53:17 +0100	[thread overview]
Message-ID: <a893750f-914c-06df-e135-7557de176957@proxmox.com> (raw)
In-Reply-To: <20201124105811.1416723-1-a.antreich@proxmox.com>

high level comment

it seems the series depends on pg autoscaling to be enabled, but on my
nautilus installation it was not

so i'd say we have to handle that by not querying autoscaling settings
if it is disabled or wrapping the mon call in an eval, else the whole 
pool view does not work
(i get an 500)

On 11/24/20 11:58 AM, Alwin Antreich wrote:
> This set allows to edit pools via GUI & CLI. This should make it easier
> for users to adjust pool settings, since they don't have to go the ceph
> tool route.
> 
> v1 -> v2:
>      - move pools endpoint to a subclass
>      - add pg autsocale status and settings
>      - rework and flatten the grid view of ceph pools
>      - rework the create input panel
>      - add an edit button using the reworked input panel
>      - fix borken add_storages
>      - extend setp_pool function to avoid a race condition
>      - remove the pg_autoscale_mode default to allow Ceph's setting to
>        take precedence
> 
> 
> Alwin Antreich (8):
>    api: ceph: subclass pools
>    ceph: add get api call for single pool
>    ceph: add autoscale_status to api calls
>    ceph: gui: add autoscale & flatten pool view
>    ceph: gui: rework pool input panel
>    ceph: schema: change min. required PG count to 1
>    ceph: remove the pg_autoscale_mode default
>    fix: ceph: always set pool size first
> 
>   PVE/API2/Ceph/Makefile    |   1 +
>   PVE/API2/Ceph.pm          | 380 +------------------------
>   PVE/API2/Ceph/POOLS.pm    | 572 ++++++++++++++++++++++++++++++++++++++
>   PVE/CLI/pveceph.pm        |  12 +-
>   PVE/Ceph/Tools.pm         |  70 ++++-
>   www/manager6/ceph/Pool.js | 405 +++++++++++++++++++--------
>   6 files changed, 950 insertions(+), 490 deletions(-)
>   create mode 100644 PVE/API2/Ceph/POOLS.pm
> 





      parent reply	other threads:[~2020-11-24 13:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24 10:58 Alwin Antreich
2020-11-24 10:58 ` [pve-devel] [PATCH manager v2 1/8] api: ceph: subclass pools Alwin Antreich
2020-11-24 13:53   ` Dominik Csapak
2020-11-24 10:58 ` [pve-devel] [PATCH manager v2 2/8] ceph: add get api call for single pool Alwin Antreich
2020-11-24 13:53   ` Dominik Csapak
2020-11-24 10:58 ` [pve-devel] [PATCH manager v2 3/8] ceph: add autoscale_status to api calls Alwin Antreich
2020-11-24 13:53   ` Dominik Csapak
2020-11-24 10:58 ` [pve-devel] [PATCH manager v2 4/8] ceph: gui: add autoscale & flatten pool view Alwin Antreich
2020-11-24 13:53   ` Dominik Csapak
2020-11-24 10:58 ` [pve-devel] [PATCH manager v2 5/8] ceph: gui: rework pool input panel Alwin Antreich
2020-11-24 13:53   ` Dominik Csapak
2020-11-24 10:58 ` [pve-devel] [PATCH manager v2 6/8] ceph: schema: change min. required PG count Alwin Antreich
2020-11-24 10:58 ` [pve-devel] [PATCH manager v2 7/8] ceph: remove the pg_autoscale_mode default Alwin Antreich
2020-11-24 10:58 ` [pve-devel] [PATCH manager v2 8/8] fix: ceph: always set pool size first Alwin Antreich
2020-11-24 13:53 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a893750f-914c-06df-e135-7557de176957@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=a.antreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal