From: aderumier@odiso.com
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 4/6] api2: add cloudinit config api
Date: Thu, 01 Apr 2021 02:16:25 +0200 [thread overview]
Message-ID: <a85b7b5614a9e9558da3ef556e0dd9639e525777.camel@odiso.com> (raw)
In-Reply-To: <7e6302d05f4098b24891a1fc29e4654de51e47d5.camel@odiso.com>
Le mercredi 31 mars 2021 à 19:32 +0200, aderumier@odiso.com a écrit :
> hi,
>
> > Why do you add the macaddress here? I couldn't find anything in
> > this
> > nor
> > in the previous patch series explaining why this is done.
>
> This is mostly to show to user that config drive need to be
> regenereted.
and also, if user delete the nic, but not ipconfig, the diff display
the missing mac, so ipconfig is pending, even if user try to regenerate
the drive.
(Currently, if we delete the iface, the ipconfig is not displayed
anymore in gui, but value is still in vm config file)
next prev parent reply other threads:[~2021-04-01 0:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 15:11 [pve-devel] [PATCH qemu-server 0/6] cloudinit pending behaviour change Alexandre Derumier
2021-03-28 15:11 ` [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config Alexandre Derumier
2021-03-31 14:10 ` Mira Limbeck
2021-04-01 8:54 ` Thomas Lamprecht
2021-04-01 10:22 ` aderumier
2021-04-02 9:22 ` aderumier
2021-04-04 12:12 ` alexandre derumier
2021-03-28 15:11 ` [pve-devel] [PATCH qemu-server 2/6] generate cloudinit drive on offline plug Alexandre Derumier
2021-03-28 15:12 ` [pve-devel] [PATCH qemu-server 3/6] cloudinit: make cloudnit options fastplug Alexandre Derumier
2021-03-28 15:12 ` [pve-devel] [PATCH qemu-server 4/6] api2: add cloudinit config api Alexandre Derumier
2021-03-31 14:13 ` Mira Limbeck
2021-03-31 17:32 ` aderumier
2021-04-01 0:16 ` aderumier [this message]
2021-03-28 15:12 ` [pve-devel] [PATCH qemu-server 5/6] api2: add cloudinit_update Alexandre Derumier
2021-03-28 15:12 ` [pve-devel] [PATCH qemu-server 6/6] add cloudinit hotplug Alexandre Derumier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85b7b5614a9e9558da3ef556e0dd9639e525777.camel@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox