From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 qemu] fix #4726: avoid superfluous check in vma code
Date: Wed, 3 Jul 2024 11:03:21 +0200 [thread overview]
Message-ID: <a823c527-353c-4d30-930d-dab6d92dabdf@proxmox.com> (raw)
In-Reply-To: <20240614110042.56739-1-f.ebner@proxmox.com>
Am 14.06.24 um 13:00 schrieb Fiona Ebner:
> The 'status' pointer is dereferenced regardless of the NULL check,
> i.e. 'status->closed' is accessed after the branch with the check.
> Since all callers pass in the address of a struct on the stack, the
> pointer can never be NULL. Remove the superfluous check and add an
> assert instead.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
applied with Fabian's R-b given for v1, because it's the very same
change, but v2 has a slightly improved commit message.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-03 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 11:00 [pve-devel] " Fiona Ebner
2024-07-03 9:03 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a823c527-353c-4d30-930d-dab6d92dabdf@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox