Re: [pve-devel] [PATCH v1 pve-common 05/18] pbsclient: use cond. statements instead of chained 'or' operators

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Max Carrara <m.carrara@proxmox.com>
Subject: Re: [pve-devel] [PATCH v1 pve-common 05/18] pbsclient: use cond. statements instead of chained 'or' operators
Date: Mon, 11 Nov 2024 20:10:58 +0100	[thread overview]
Message-ID: <a7e179d4-df6e-4ad2-b691-9cd30afb624f@proxmox.com> (raw)
In-Reply-To: <20240802132656.270077-6-m.carrara@proxmox.com>

Am 02.08.24 um 15:26 schrieb Max Carrara:
> .. like in the `delete_encryption_key` subroutine below, as it's more
> readable at a glance.
> 
> Signed-off-by: Max Carrara <m.carrara@proxmox.com>
> ---
>  src/PVE/PBSClient.pm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/PBSClient.pm b/src/PVE/PBSClient.pm
> index ab1fa62..d707971 100644
> --- a/src/PVE/PBSClient.pm
> +++ b/src/PVE/PBSClient.pm
> @@ -77,7 +77,10 @@ sub delete_password {
>  
>      my $pwfile = password_file_name($self);
>  
> -    unlink $pwfile or $! == ENOENT or die "deleting password file failed - $!\n";

we have this pattern quite often and for unlink this is IMO really fine to do,
especially with replacing `$! == ENOENT` with `$!{ENOENT}` to avoid the need
for loading the POSIX module.

> +    if (!unlink($pwfile)) {
> +	return if $! == ENOENT;
> +	die "deleting password file failed - $!\n";
> +    }
>  };
>  
>  sub get_password {

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel