From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button
Date: Wed, 2 Aug 2023 10:02:44 +0200 [thread overview]
Message-ID: <a7cbf2bd-a0c7-4bac-a02d-3cdc13d02e38@proxmox.com> (raw)
In-Reply-To: <20230727124709.613810-1-l.wagner@proxmox.com>
Am 27/07/2023 um 14:47 schrieb Lukas Wagner:
> Before, there was zero space between the the grid border line and the
> button, making it look a bit odd.
>
> The ListField form component is currently used in the
> 'User Tag Access' and 'Registered Tags' dialog windows in datacenter
> option view.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> www/manager6/form/ListField.js | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
FWIW, it might be also look slightly better, and save some space, if we'd
move the add button inside the grid, i.e., at the right side below the last
row. Would also shorten the way one has to move between adding a new tag input
and editing that tag.
next prev parent reply other threads:[~2023-08-02 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 12:47 [pve-devel] " Lukas Wagner
2023-08-02 8:02 ` Thomas Lamprecht [this message]
2023-08-02 8:14 ` [pve-devel] applied: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7cbf2bd-a0c7-4bac-a02d-3cdc13d02e38@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox