public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES
Date: Tue, 22 Oct 2024 13:35:10 +0200	[thread overview]
Message-ID: <a70e0354-1f9f-4de9-b346-7c54775f156b@proxmox.com> (raw)
In-Reply-To: <aaa21bcb-b351-4567-9451-bc7e981268e9@proxmox.com>

Am 22/10/2024 um 13:23 schrieb Fiona Ebner:
> Am 01.10.24 um 16:08 schrieb Maximiliano Sandoval:
>> This makes it so newly created VMs, e.g. with `qm create` will have the
>> same default value as VMs created via the web UI.
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---
>> I am not entirely sure if there is side-effect that I am not taking into account.
>>
> This is a breaking change, because existing API callers now suddenly get
> a new default. Even if it were just CLI and not API, it would be
> breaking for the same reason (there are scripts using the CLI tools out
> there).
> 
> If we do this, then in a major release and prominently communicate it to
> all users in the release notes. And it should also be documented it in
> the API schema, that creation uses another default than the schema default.

And even then, would this still break restoring backups made before that
change?
If, this would fall under the changes that need versioning the guest
configs. Which naturally is possible but is IMO also not something I'd
do lightly, as that's something that might have wide-reaching consequences.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-10-22 11:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 14:08 Maximiliano Sandoval
2024-10-02  7:50 ` Shannon Sterz
2024-10-22 11:23 ` Fiona Ebner
2024-10-22 11:35   ` Thomas Lamprecht [this message]
2024-10-22 12:15     ` Maximiliano Sandoval
2024-10-22 13:35       ` Thomas Lamprecht
2024-10-23  9:56         ` Fiona Ebner
2024-10-23 11:06           ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a70e0354-1f9f-4de9-b346-7c54775f156b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal