public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC qemu-server 2/9] cfg2cmd: improve error message for invalid volume storage content type
Date: Wed, 22 Jan 2025 15:31:13 +0100	[thread overview]
Message-ID: <a6ba5827-babf-4dbb-baa4-b49a1b7bb1f2@proxmox.com> (raw)
In-Reply-To: <ea154c52-b479-4167-b061-bcd58719c451@proxmox.com>

Am 22.01.25 um 14:16 schrieb Daniel Kral:
> Thank you very much for taking a look over this!
> 
> Sorry for taking such a long time for getting back to you on this, I'll
> rework this patch series for a v2 now.
> 
> On 11/29/24 15:23, Fiona Ebner wrote:
>> Am 16.09.24 um 18:38 schrieb Daniel Kral:
>>> diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
>>> index 0afb6317..9d0f24aa 100644
>>> --- a/PVE/QemuServer/Helpers.pm
>>> +++ b/PVE/QemuServer/Helpers.pm
>>> @@ -106,6 +106,51 @@ sub vm_running_locally {
>>>       return;
>>>   }
>>>   +=head3 check_storage_content_type($storecfg, $storeid [,
>>> $content_type])
>>
>> Usually, "assert_" rather than "check_" is used for such helpers that
>> die upon failing the check, so maybe "assert_content_type_supported"
>>
>> Nit: there is no blank line below the header when viewed with perldoc
> 
> Hm, I'm sure it's possible but a quick glance over some other perldocs
> showed me that other perldocs don't seem to add a blank line below the
> function signature either (I looked at `AnyEvent::HTTP` and
> `Archive::Cpio` specifically, but they also seem to not follow the
> `head3` as we do).
> 
> Do you have a reference that I can see how documentation should be
> formatted?
> 

We do not have a reference except what Max was working on, but that is
an RFC, see "Perl Documentation" in the internal wiki. But I suppose
it's fine without a blank, we already went with this for e.g.
Storage/Common.pm


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-01-22 14:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16 16:38 [pve-devel] [RFC qemu-server 0/9] consistent checks for storage content types on volume disk allocation Daniel Kral
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 1/9] test: cfg2cmd: expect error for invalid volume's storage content type Daniel Kral
2024-11-29 14:23   ` Fiona Ebner
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 2/9] cfg2cmd: improve error message for invalid volume " Daniel Kral
2024-11-29 14:23   ` Fiona Ebner
2025-01-22 13:16     ` Daniel Kral
2025-01-22 14:31       ` Fiona Ebner [this message]
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 3/9] fix #5284: move_vm: add check if target storage supports vm images Daniel Kral
2024-11-29 14:23   ` Fiona Ebner
2025-01-22 13:18     ` Daniel Kral
2025-01-22 13:43       ` Daniel Kral
2025-01-22 14:35       ` Fiona Ebner
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 4/9] api: clone_vm: add check if " Daniel Kral
2024-11-29 14:23   ` Fiona Ebner
2025-01-22 13:18     ` Daniel Kral
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 5/9] api: create_vm: improve checks if storages for disks support " Daniel Kral
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 6/9] cloudinit: add check if storage for cloudinit disk supports " Daniel Kral
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 7/9] api: migrate_vm: improve check if target storages support " Daniel Kral
2024-11-29 14:23   ` Fiona Ebner
2025-01-22 13:19     ` Daniel Kral
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 8/9] api: importdisk: improve check if storage supports " Daniel Kral
2024-09-16 16:38 ` [pve-devel] [RFC qemu-server 9/9] restore_vm: improve checks " Daniel Kral
2024-11-29 14:23   ` Fiona Ebner
2025-01-22 13:21     ` Daniel Kral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6ba5827-babf-4dbb-baa4-b49a1b7bb1f2@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal