From: Dominik Csapak <d.csapak@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/3] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s
Date: Thu, 22 Sep 2022 13:31:49 +0200 [thread overview]
Message-ID: <a68d9fe5-97b9-cb42-e882-9558a6b17854@proxmox.com> (raw)
In-Reply-To: <1663834293.mozxwx9wgy.astroid@nora.none>
[snip]
>> -/*
>> - * SIGALRM and cleanup handling
>> - *
>> - * terminate_client will set an alarm for 5 seconds and add its client's PID to
>> - * the forced_cleanups list - when the timer expires, we iterate the list and
>> - * attempt to issue SIGKILL to all processes which haven't yet stopped.
>> - */
>> -
>> -static void
>> -alarm_handler(__attribute__((unused)) int signum)
>> -{
>> - alarm_triggered = 1;
>> -}
>> -
>
> wasn't this intentionally decoupled like this?
>
> alarm_handler just sets the flag
> actual force cleanup is conditionalized on the alarm having triggered,
> but the cleanup happens outside of the signal handler..
>
> is there a reason from switching away from these scheme? we don't need
> to do the cleanup in the signal handler (timing is already plenty fuzzy
> anyway ;))
no real reason, i found the code somewhat cleaner, but you're right,
we probably want to keep that, and just trigger it regularly
>
>> static void
>> sigkill(void *ptr, __attribute__((unused)) void *unused)
>> {
>> struct CleanupData data = *((struct CleanupData *)ptr);
>> int err;
>>
>> + if (data.timeout > time(NULL)) {
>
> nit: current time / cutoff could be passed in via the currently unused
> user_data parameter..
>
make sense
next prev parent reply other threads:[~2022-09-22 11:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:49 [pve-devel] [PATCH qemu-server 0/3] qmeventd: improve shutdown behaviour Dominik Csapak
2022-09-21 12:49 ` [pve-devel] [PATCH qemu-server 1/3] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s Dominik Csapak
[not found] ` <<20220921124911.3224970-2-d.csapak@proxmox.com>
2022-09-22 8:24 ` Fabian Grünbichler
2022-09-22 11:31 ` Dominik Csapak [this message]
2022-09-22 12:01 ` Wolfgang Bumiller
2022-09-22 12:22 ` Dominik Csapak
2022-09-22 12:46 ` Wolfgang Bumiller
2022-09-22 11:51 ` Thomas Lamprecht
2022-09-21 12:49 ` [pve-devel] [PATCH qemu-server 2/3] qmeventd: cancel 'forced cleanup' when normal cleanup succeeds Dominik Csapak
2022-09-22 10:14 ` Matthias Heiserer
2022-09-22 11:37 ` Dominik Csapak
2022-09-23 7:58 ` Wolfgang Bumiller
2022-09-21 12:49 ` [pve-devel] [PATCH qemu-server 3/3] qmeventd: send QMP 'quit' command instead of SIGTERM Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a68d9fe5-97b9-cb42-e882-9558a6b17854@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox