From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH-SERIES qemu-server v2 0/8] cpu config: support aarch64 CPU models
Date: Tue, 3 Feb 2026 15:48:51 +0100 [thread overview]
Message-ID: <a620baa7-415a-46c0-8ab4-ab5835371c70@proxmox.com> (raw)
In-Reply-To: <b413f1be-36ed-4f72-839d-637b8fd9bc48@proxmox.com>
Am 03.02.26 um 15:08 schrieb Dominik Csapak:
> I'm not a super fan of "sprinkling" `eq 'x86_64'` or similar throughout
> the code, but for the cases used here it's probably ok.
>
> If we encounter more such things though, I'd really like some
> more general lookup for arch -> values or something like this.
>
> even if it's just a 'supports_x' helper that has a hash
> like
> {
> x86_64 => 1,
> aarch64 => 0,
> xxx => yyy,
> }
> etc
>
> But as I wrote, for these use cases here probably ok, and
> definitely no blocker for now since that can be cleaned
> up whenever we see fit.
FWIW, this is also something I noticed, but I too found it OK
for the use case now. In the midterm it might be indeed nicer
to move those checks in local helpers like, e.g., a method named
arch_supports_hv_enlightment (and in there I would then care less
how it's checked), but again, not really a problem now.
prev parent reply other threads:[~2026-02-03 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 13:09 Fiona Ebner
2026-01-29 13:09 ` [PATCH qemu-server v2 1/8] cpu config: introduce pve-qm-cpu-arch standard option for virtual CPU architecture Fiona Ebner
2026-01-29 13:09 ` [PATCH qemu-server v2 2/8] cpu config: guard adding hyperv enlightenments by arch Fiona Ebner
2026-01-29 13:10 ` [PATCH qemu-server v2 3/8] cpu config: 'hidden' option only applies to vCPUs with x86_64 arch Fiona Ebner
2026-01-29 13:10 ` [PATCH qemu-server v2 4/8] cpu config: introduce module-wide $host_arch variable Fiona Ebner
2026-02-03 13:51 ` Thomas Lamprecht
[not found] ` <f567ae7c-39aa-40bb-9270-5f7cec6560eb@kohly.de>
2026-02-03 16:21 ` Thomas Lamprecht
2026-01-29 13:10 ` [PATCH qemu-server v2 5/8] cpu config: support aarch64 CPU models Fiona Ebner
2026-01-29 13:10 ` [PATCH qemu-server v2 6/8] api: cpu: allow querying CPU models for a given architecture Fiona Ebner
2026-01-29 13:10 ` [PATCH qemu-server v2 7/8] cpu config: support aarch64 CPU flags Fiona Ebner
2026-01-29 13:10 ` [PATCH qemu-server v2 8/8] api: cpu flags: allow querying CPU flags for a given architecture Fiona Ebner
2026-02-03 14:09 ` [PATCH-SERIES qemu-server v2 0/8] cpu config: support aarch64 CPU models Dominik Csapak
2026-02-03 14:48 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a620baa7-415a-46c0-8ab4-ab5835371c70@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox