From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH-SERIES manager/proxmox-ve] warn against/prevent using virtual console for major upgrade
Date: Fri, 29 Oct 2021 11:32:24 +0200 [thread overview]
Message-ID: <a61c8a83-ed24-4637-0cc1-959f3abcecb2@proxmox.com> (raw)
In-Reply-To: <20210913120446.23392-1-f.ebner@proxmox.com>
Could I get some feedback for this?
Am 13.09.21 um 14:04 schrieb Fabian Ebner:
> Quoting from the upgrade notes:
>
>> Perform the actions via console or ssh; preferably via console to avoid
>> interrupted ssh connections. Do not carry out the upgrade when connected
>> via the virtual console offered by the GUI; as this will get interrupted
>> during the upgrade.
>
> But some users still seem to miss this, so let's be more direct.
>
> One part is proxmox-ve patches #1 and #2, just mentioning it up front.
>
> The other two patches (sent as RFC, as I'm not sure this is the best
> approach), would make it a hard error when a console started via
> API/GUI is detected upon attempting a major upgrade.
>
>
> All patches are also intended for stable-6. Note that proxmox-ve does
> not currently have a stable-6 branch, I used
> 286285a9a441ad5b1a3c1869373bfbaadbb70bb4 as a base when testing.
>
>
> proxmox-ve depends on pve-manager for the new behavior to take effect,
> but it's not a hard dependency.
>
>
> pve-manager:
>
> Fabian Ebner (1):
> api: nodes: set environment variable for shells started via the API
>
> PVE/API2/Nodes.pm | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>
> proxmox-ve:
>
> Fabian Ebner (3):
> apt hook: avoid long line and fix typo
> apt hook: mention that console/ssh should be used for major upgrade
> apt hook: disallow major upgrade via virtual console from API/UI
>
> debian/apthook/pve-apt-hook | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
prev parent reply other threads:[~2021-10-29 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 12:04 Fabian Ebner
2021-09-13 12:04 ` [pve-devel] [RFC manager 1/1] api: nodes: set environment variable for shells started via the API Fabian Ebner
2021-09-13 12:26 ` Fabian Ebner
2021-09-13 12:04 ` [pve-devel] [PATCH proxmox-ve 1/3] apt hook: avoid long line and fix typo Fabian Ebner
2021-09-13 12:04 ` [pve-devel] [PATCH proxmox-ve 2/3] apt hook: mention that console/ssh should be used for major upgrade Fabian Ebner
2021-09-13 12:04 ` [pve-devel] [RFC proxmox-ve 3/3] apt hook: disallow major upgrade via virtual console from API/UI Fabian Ebner
2021-10-29 9:32 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a61c8a83-ed24-4637-0cc1-959f3abcecb2@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox