From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 container] fix #4192: revamp check for systemd version
Date: Tue, 8 Nov 2022 18:23:17 +0100 [thread overview]
Message-ID: <a5d12f86-4a10-4d4f-067e-07defe050aa7@proxmox.com> (raw)
In-Reply-To: <20220915115228.117543-1-l.nunner@proxmox.com>
Am 15/09/2022 um 13:52 schrieb Leo Nunner:
> Instead of iterating through several folders, it might just be easier to
> check the objdump output of /sbin/init and getting the version from there.
> Resolving the /sbin/init symlink happens inside the chroot, but the
> objdump from the host system is used, as to not run any untrusted
> executables.
>
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> I think putting the subroutine to resolve the /sbin/init symlink into
> Setup.pm makes the most sense, since this isn't realy a task for the
> plugin.
>
> src/PVE/LXC/Setup.pm | 18 +++++++++++++++++-
> src/PVE/LXC/Setup/Alpine.pm | 2 +-
> src/PVE/LXC/Setup/Base.pm | 34 ++++++++++++++++++----------------
> src/PVE/LXC/Setup/Devuan.pm | 2 +-
> src/PVE/LXC/Setup/Plugin.pm | 2 +-
> src/PVE/LXC/Setup/Unmanaged.pm | 2 +-
> 6 files changed, 39 insertions(+), 21 deletions(-)
>
>
applied, with a small followup for a few small white-space/indentation errors,
otherwise nice work - thanks!
next prev parent reply other threads:[~2022-11-08 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 11:52 [pve-devel] " Leo Nunner
2022-11-08 17:23 ` Thomas Lamprecht [this message]
2022-11-16 12:13 ` Thomas Lamprecht
2022-11-16 12:14 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5d12f86-4a10-4d4f-067e-07defe050aa7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox