From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: storage backup view: Update remove button on protection change
Date: Wed, 18 Jan 2023 14:53:07 +0100 [thread overview]
Message-ID: <a5b4212b-854f-a40d-895e-5d992e993932@proxmox.com> (raw)
In-Reply-To: <20230118130135.631553-1-c.heiss@proxmox.com>
Looks ok (but did not tested it yet), few small nits inline
Am 18/01/2023 um 14:01 schrieb Christoph Heiss:
> Currently this works in the backup view for containers/VMs, but not in
> the storage backup view. Implement that for the latter part too.
>
> Uses the callback functionality of the load() method of the store to
> properly update the UI as soon as loading is finished.
> While at it, clean up the same thing in grid/BackupView.js to remove the
replace file name with (parts of) the module name or xtype.
> current hack.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> FWIW, using me.store.load({..}) directly in grid/BackupView.js works
> perfectly fine too (as I would expect). But I reused reload() for now,
> to keep consistency with the rest of the file. Thus the added `args`.
>
> www/manager6/grid/BackupView.js | 16 +++++++---------
> www/manager6/storage/BackupView.js | 6 +++++-
> 2 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/www/manager6/grid/BackupView.js b/www/manager6/grid/BackupView.js
> index 7f7e1b62..dda8a363 100644
> --- a/www/manager6/grid/BackupView.js
> +++ b/www/manager6/grid/BackupView.js
> @@ -79,9 +79,9 @@ Ext.define('PVE.grid.BackupView', {
> ]);
> };
>
> - var reload = Ext.Function.createBuffered(function() {
> + var reload = Ext.Function.createBuffered(function(args) {
two nits:
- please transform to `let` or `const` when touching anyway
- s/args/options/ to be more in line with ExtJS terminology [0] for this parameter
as otherwise it somewhat suggests one could pass arbitrary `arguments`.
[0]: https://docs.sencha.com/extjs/7.0.0/classic/Ext.data.Store.html#method-load
> if (me.store) {
> - me.store.load();
> + me.store.load(args);
> }
> }, 100);
>
prev parent reply other threads:[~2023-01-18 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 13:01 Christoph Heiss
2023-01-18 13:53 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5b4212b-854f-a40d-895e-5d992e993932@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox