From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix #3683: agent file-write: enable user to encode the content themselves
Date: Thu, 10 Feb 2022 16:31:27 +0100 [thread overview]
Message-ID: <a4da632c-3915-364e-bcbc-4cef68d96824@proxmox.com> (raw)
In-Reply-To: <20220210145210.1254509-1-d.csapak@proxmox.com>
On 10.02.22 15:52, Dominik Csapak wrote:
> by adding an optional parameter 'encode' (enabled by default). When it
> is disabled, the content must be base64 encoded already. This
> way, users can send a binary file to the vm by base64 encoding it
> themselves
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/API2/Qemu/Agent.pm | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
>
applied, with some cleanups in general as followup and another one dropping
the base64 check with the assumption that it can be relatively expensive, the
user needs to turn off auto-encode explicitly already and QEMU/QGA should be
able to cope with bogus input - or do you know a case when this isn't true?
As then we can just revert it again.
thanks!
next prev parent reply other threads:[~2022-02-10 15:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 14:52 [pve-devel] " Dominik Csapak
2022-02-10 15:31 ` Thomas Lamprecht [this message]
2022-02-11 7:20 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4da632c-3915-364e-bcbc-4cef68d96824@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox