From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES v2] loosen up mailto regex for backwards compatibility
Date: Wed, 17 Feb 2021 11:35:26 +0100 [thread overview]
Message-ID: <a4bb7cb1-e235-cdc5-3ef7-c43a49003851@proxmox.com> (raw)
In-Reply-To: <27e9623d-8765-010a-3015-a13d34db6fec@proxmox.com>
On 17.02.21 10:52, Dominik Csapak wrote:
> LGTM, nothing obvious that is wrong
> one small thing though, after this patch i cannot
> have an @ in the local part of an email anymore, though
> i do not think that people actually use that?
>
> e.g. foo@bar@example.com does not work anymore
>
Thanks for the review and for catching that! I'll send a follow-up (or
does this warrant a v3?) including '@' in the local part, and check that
other users of the 'email' format are not confused by that in some way.
> Other than that, i tested it and worked as advertised
>
> Reviewed-By: Dominik Csapak <d.csapak@proxmox.com>
>
> On 2/15/21 13:24, Fabian Ebner wrote:
>> especially regarding the whitespace-agnostic behavior. And while we're
>> at it,
>> also use the more complete email regex from pve-common.
>>
>> Changes from v1:
>> * re-use the email regex from pve-common
>> * improve printing out mailto parameters to the cron file
>>
>>
>> common:
>>
>> Fabian Ebner (2):
>> sendmail: use more complete email regex and shellquote
>> register email-or-username format
>>
>> src/PVE/JSONSchema.pm | 14 +++++++++++++-
>> src/PVE/Tools.pm | 17 ++++++++++++-----
>> 2 files changed, 25 insertions(+), 6 deletions(-)
>>
>>
>> guest-common:
>>
>> Fabian Ebner (3):
>> vzdump: command line: refactor handling prune-backups
>> vzdump: command line: make sure mailto is comma-separated
>> vzdump: mailto: use email-or-username-list format
>>
>> PVE/VZDump/Common.pm | 14 +++++---------
>> 1 file changed, 5 insertions(+), 9 deletions(-)
>>
>>
>> manager:
>>
>> Fabian Ebner (3):
>> vzdump: refactor parsing mailto so it can be mocked
>> test: vzdump: add tests for mailto
>> test: vzdump: rename vzdump_new_retention_test.pl to
>> vzdump_new_test.pl
>>
>> PVE/API2/VZDump.pm | 11 +-
>> PVE/VZDump.pm | 21 +++
>> test/Makefile | 8 +-
>> ...w_retention_test.pl => vzdump_new_test.pl} | 174 +++++++++++++++++-
>> 4 files changed, 198 insertions(+), 16 deletions(-)
>> rename test/{vzdump_new_retention_test.pl => vzdump_new_test.pl} (74%)
>>
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2021-02-17 10:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 12:24 Fabian Ebner
2021-02-15 12:24 ` [pve-devel] [PATCH v2 common 1/8] sendmail: use more complete email regex and shellquote Fabian Ebner
2021-02-18 11:54 ` [pve-devel] applied: " Thomas Lamprecht
2021-02-15 12:24 ` [pve-devel] [PATCH v2 common 2/8] register email-or-username format Fabian Ebner
2021-02-18 11:54 ` [pve-devel] applied: " Thomas Lamprecht
2021-02-15 12:24 ` [pve-devel] [PATCH v2 guest-common 3/8] vzdump: command line: refactor handling prune-backups Fabian Ebner
2021-02-15 12:24 ` [pve-devel] [PATCH v2 guest-common 4/8] vzdump: command line: make sure mailto is comma-separated Fabian Ebner
2021-02-15 12:24 ` [pve-devel] [PATCH v2 guest-common 5/8] vzdump: mailto: use email-or-username-list format Fabian Ebner
2021-02-15 12:25 ` [pve-devel] [PATCH v2 manager 6/8] vzdump: refactor parsing mailto so it can be mocked Fabian Ebner
2021-02-15 12:25 ` [pve-devel] [PATCH v2 manager 7/8] test: vzdump: add tests for mailto Fabian Ebner
2021-02-15 12:25 ` [pve-devel] [PATCH v2 manager 8/8] test: vzdump: rename vzdump_new_retention_test.pl to vzdump_new_test.pl Fabian Ebner
2021-02-17 9:52 ` [pve-devel] [PATCH-SERIES v2] loosen up mailto regex for backwards compatibility Dominik Csapak
2021-02-17 10:35 ` Fabian Ebner [this message]
2021-02-17 11:42 ` Fabian Ebner
2021-02-19 15:36 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4bb7cb1-e235-cdc5-3ef7-c43a49003851@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox