Re: [PATCH container v2] fix #7164: lxc: restore: apply password and ssh keys during container restore

[Erik Fastermann <e.fastermann@proxmox.com>]

[snip]

>>> Add `check_systemd_nesting` to the `post_restore_hook`.
>>
>> Why is this added? A rational here would be helpful. If the reason is
>> just symmetry with `post_create_hook`, we might need to be careful here,
>> as this could introduce new unwanted failure conditions. I have not
>> checked in detail, but some of the code can die.
> 
> I believed adding this check might make the restore process more resiliant
> since the user might get important warnings early, thus reducing the amount
> of troubleshooting needed.
> 
> But as you pointed out, this could lead to a regression.
> 
> Since a restore is technically a creating a new contaienrs, i felt as
> though adding this check made sense. Perhaps the `die` is a good thing?
> Alerting the user early regarding potential issues, might be beneficial.
> 
> I am curious to know what your opinion is on this! After more consideration
> I am strongly considering omitting the check.
> 

More checks are usually good and I currently don't see a concrete 
use-case where having this check would break something. I still would 
prefer if this was an additional patch as it is unrelated to the 
original fix.

[snip]