From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: Re: [PATCH widget-toolkit 1/2] apt repositories: fix typo for getting the default unknown text
Date: Fri, 9 Jun 2023 17:35:08 +0200 [thread overview]
Message-ID: <a43d79b8-e8eb-0b6a-613a-23d84022b70a@proxmox.com> (raw)
In-Reply-To: <20230609141626.4766-1-f.ebner@proxmox.com>
On 09/06/2023 16:16, Fiona Ebner wrote:
> Could lead to a type error with classifyOrigin when there is a
> repository that doesn't have an InRelease file and cannot be detected
> as Debian/Proxmox origin from its URL. For me, it triggered with the
> element.io repository after changing to bookworm (which currently
> doesn't exist yet) and running apt update.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Not too difficult to run into with external repos during upgrade
> preparation (when they are not yet bookworm-ready), so might also be
> worth it for the stable branch?
>
> src/node/APTRepositories.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied both patches to master for now, thanks!
prev parent reply other threads:[~2023-06-09 15:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 14:16 [pve-devel] " Fiona Ebner
2023-06-09 14:16 ` [pve-devel] [PATCH widget-toolkit 2/2] apt repositories: avoid potential type error in classifyOrigin helper Fiona Ebner
2023-06-09 15:35 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a43d79b8-e8eb-0b6a-613a-23d84022b70a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox