From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
alexandre derumier <aderumier@odiso.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu] drop patch force-disabling smm
Date: Mon, 23 Aug 2021 18:01:41 +0200 [thread overview]
Message-ID: <a3b857c4-c8fa-c14c-a306-bb46974cd611@proxmox.com> (raw)
In-Reply-To: <71d62f433be447c0201e168f20934f351a210448.camel@odiso.com>
On 10/08/2021 15:47, alexandre derumier wrote:
> Le mardi 10 août 2021 à 09:55 +0200, Wolfgang Bumiller a écrit :
>> This drops debian/patches/pve/0005-PVE-Config-smm_available-
>> false.patch
>> (and renumbers the remaining patches)
>>
>> From what I could gather, this patch was originally added
>> due to issues with old kernels. Now we have users which
>> seem to run into issues *with* the patch.
> yes indeed, this was old kernel with some old processors.
>
>
> Just be carefull with live migration, I wonder if it's not breaking
> migration it you just remove it like that.
> (Maybe it could be better to remove it for qemu > 6.1, it should be
> tested)
>
Did anybody tested this on live migration (on a system where it would
actually toggle to true)?
If it breaks that we'd need to fallback to the old "false" with a QEMU
machine version check and we could only drop it then in PVE 8.0, so hopefully
it Just Works™ to safe that hassle..
next prev parent reply other threads:[~2021-08-23 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 7:55 Wolfgang Bumiller
2021-08-10 13:47 ` alexandre derumier
2021-08-23 16:01 ` Thomas Lamprecht [this message]
2021-08-24 8:52 ` Stefan Reiter
2021-08-24 9:19 ` [pve-devel] applied: " Thomas Lamprecht
2021-08-24 9:24 ` Wolfgang Bumiller
2021-08-24 9:28 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3b857c4-c8fa-c14c-a306-bb46974cd611@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox