From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH qemu-server 0/2] migration: fix sporadic nbd-server-stop timeout
Date: Fri, 29 Sep 2023 13:57:29 +0200 [thread overview]
Message-ID: <a354ace2-f966-1e42-828f-c95d3d235dfc@proxmox.com> (raw)
In-Reply-To: <20230929082859.147270-1-aderumier@odiso.com>
Am 29.09.23 um 10:28 schrieb Alexandre Derumier:
> I'm not sure, maybe it's related to writeback, because it never happend with a fresh started vm, but vms running since some time can trigger this.
> (I'm not sure, maybe nbd need to flush pending datas in cache ?)
>
It does drain the export's BlockBackend, i.e. wait for all pending IO
before detaching/closing the export. But we did cancel the mirror job,
which should actually wait for any in-flight IO already, so it's a bit
surprising. Maybe there's some cache interaction happening at an
inconvenient time, no idea ¯\_(ツ)_/¯
The other thing it does is closing the connection to the client, so
there is at least that IO interaction and a higher timeout makes sense.
>
> Alexandre Derumier (2):
> nbd_stop: increase timeout to 25s
> migration: add missing eval on nbdstop with tunnel v2.
>
Patches look good to me, so consider them
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
but they are missing your Signed-off-by trailer. Can you please add that?
next prev parent reply other threads:[~2023-09-29 11:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 8:28 Alexandre Derumier
2023-09-29 8:28 ` [pve-devel] [PATCH qemu-server 1/2] nbd_stop: increase timeout to 25s Alexandre Derumier
2023-09-29 8:28 ` [pve-devel] [PATCH qemu-server 2/2] migration: add missing eval on nbdstop with tunnel v2 Alexandre Derumier
2023-09-29 11:57 ` Fiona Ebner [this message]
2023-11-06 18:48 ` [pve-devel] applied: [PATCH qemu-server 0/2] migration: fix sporadic nbd-server-stop timeout Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a354ace2-f966-1e42-828f-c95d3d235dfc@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox