From: Stefan Sterz <s.sterz@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH common] fix #5034 ldap attribute regex
Date: Wed, 15 Nov 2023 16:02:39 +0100 [thread overview]
Message-ID: <a334115c-55bd-456d-99b7-dc8d2203f51d@proxmox.com> (raw)
In-Reply-To: <2a01ac45-0918-4973-b20d-8f21cf1dd99c@proxmox.com>
On 15.11.23 14:28, Stefan Sterz wrote:
>> src/PVE/JSONSchema.pm | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm
>> index 49e0d7a..ef58b62 100644
>> --- a/src/PVE/JSONSchema.pm
>> +++ b/src/PVE/JSONSchema.pm
>> @@ -408,7 +408,7 @@ PVE::JSONSchema::register_format('ldap-simple-attr', \&verify_ldap_simple_attr);
>> sub verify_ldap_simple_attr {
>> my ($attr, $noerr) = @_;
>>
>> - if ($attr =~ m/^[a-zA-Z0-9]+$/) {
>> + if ($attr =~ m/^[a-zA-Z0-9\-]+$/) {
>
> if i'm not mistaken, this regex should try to filter an `AttributeValue`
> [1]. in case we do stick with this regex approach here, you may want to
> relax this even further, as per the standard:
>
sorry just noticed i forgot to add:
[1]: https://datatracker.ietf.org/doc/html/rfc4514#section-2.4
next prev parent reply other threads:[~2023-11-15 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 12:23 Markus Frank
2023-11-15 13:28 ` Stefan Sterz
2023-11-15 14:49 ` Thomas Lamprecht
2023-11-15 15:12 ` Stefan Sterz
2023-11-15 15:48 ` Thomas Lamprecht
2023-11-15 15:02 ` Stefan Sterz [this message]
2023-11-15 13:30 ` Thomas Lamprecht
2023-11-21 12:55 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a334115c-55bd-456d-99b7-dc8d2203f51d@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox