From: Anton Iacobaeus <anton.iacobaeus@canarybit.eu>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
Subject: Re: [pve-devel] [PATCH edk2-firmware v2 2/3] Add firmware target for TDFV
Date: Mon, 13 Oct 2025 16:02:18 +0200 [thread overview]
Message-ID: <a2fb6e35-d997-47c4-b424-9c6de4d1f981@canarybit.eu> (raw)
In-Reply-To: <29a9f159-a7eb-4dc8-8d2e-1836497467ce@proxmox.com>
On 10/7/25 17:24, Fiona Ebner wrote:
> Am 04.10.25 um 3:23 PM schrieb Anton Iacobaeus:
>> From: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
>>
>> TDVF enables UEFI support for TDX virtual machines. Add a build target
>> to build TDFV in Config-B (https://github.com/tianocore/edk2/tree/master/OvmfPkg/IntelTdx#configurations-and-features)
>
> Would be great to have a 1-2 sentences for the rationale why this
> variant was chosen in the commit message. I suppose because the other
> one isn't fully featured?
>
>> Signed-off-by: Philipp Giersfeld <philipp.giersfeld@canarybit.eu>
>> Signed-off-by: Anton Iacobaeus <anton.iacobaeus@canarybit.eu>
>
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
>
That is exactly right, I will add some details to the commit message.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-13 14:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 15:11 [pve-devel] [PATCH edk2-firmware/manager/qemu-server v2 0/7] Add support for Intel TDX Anton Iacobaeus
2025-10-01 15:11 ` [pve-devel] [PATCH edk2-firmware v2 1/3] Change name of SEV-related OVMF files Anton Iacobaeus
2025-10-07 15:24 ` Fiona Ebner
2025-10-01 15:11 ` [pve-devel] [PATCH edk2-firmware v2 2/3] Add firmware target for TDFV Anton Iacobaeus
2025-10-07 15:24 ` Fiona Ebner
2025-10-13 14:02 ` Anton Iacobaeus [this message]
2025-10-01 15:11 ` [pve-devel] [PATCH edk2-firmware v2 3/3] Add SCSI in NCCFV for TD guest Anton Iacobaeus
2025-10-07 15:24 ` Fiona Ebner
2025-10-13 14:02 ` Anton Iacobaeus
2025-10-14 7:50 ` Fiona Ebner
2025-10-01 15:11 ` [pve-devel] [PATCH manager v2 1/1] Add support for Intel TDX Anton Iacobaeus
2025-10-01 15:11 ` [pve-devel] [PATCH qemu-server v2 1/3] Adapt AMD SEV code for compatibility with other platforms Anton Iacobaeus
2025-10-07 15:24 ` Fiona Ebner
2025-10-01 15:11 ` [pve-devel] [PATCH qemu-server v2 2/3] Add check for TDX support Anton Iacobaeus
2025-10-08 10:06 ` Fiona Ebner
2025-10-01 15:11 ` [pve-devel] [PATCH qemu-server v2 3/3] Add support for Intel TDX Anton Iacobaeus
2025-10-08 10:21 ` Fiona Ebner
2025-10-13 9:30 ` Fiona Ebner
2025-10-13 14:25 ` Anton Iacobaeus
2025-10-14 7:50 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2fb6e35-d997-47c4-b424-9c6de4d1f981@canarybit.eu \
--to=anton.iacobaeus@canarybit.eu \
--cc=f.ebner@proxmox.com \
--cc=philipp.giersfeld@canarybit.eu \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox