* [pve-devel] [PATCH widget-toolkit] panel/RRDChart: fix animation settings for highlight/marker
@ 2021-05-27 13:15 Dominik Csapak
2021-05-28 8:43 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-05-27 13:15 UTC (permalink / raw)
To: pve-devel
in extjs 7.0, the marker does not have the 'fx' property anymore,
but the now documented 'animation' property does not work as it seems.
instead set the animation settings directly on the chart. The only
downside is that this is now for *all* animations, not only the
fade in of the highlight. (the default duration is 500ms)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/panel/RRDChart.js | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js
index 859cb39..517c45d 100644
--- a/src/panel/RRDChart.js
+++ b/src/panel/RRDChart.js
@@ -246,10 +246,6 @@ Ext.define('Proxmox.widget.RRDChart', {
marker: {
opacity: 0,
scaling: 0.01,
- fx: {
- duration: 200,
- easing: 'easeOut',
- },
},
highlightCfg: {
opacity: 1,
@@ -266,7 +262,10 @@ Ext.define('Proxmox.widget.RRDChart', {
// enable animation after the store is loaded
me.store.onAfter('load', function() {
- me.setAnimation(true);
+ me.setAnimation({
+ duration: 200,
+ easing: 'easeIn',
+ });
}, this, { single: true });
},
});
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH widget-toolkit] panel/RRDChart: fix animation settings for highlight/marker
2021-05-27 13:15 [pve-devel] [PATCH widget-toolkit] panel/RRDChart: fix animation settings for highlight/marker Dominik Csapak
@ 2021-05-28 8:43 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-05-28 8:43 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 27.05.21 15:15, Dominik Csapak wrote:
> in extjs 7.0, the marker does not have the 'fx' property anymore,
> but the now documented 'animation' property does not work as it seems.
>
> instead set the animation settings directly on the chart. The only
> downside is that this is now for *all* animations, not only the
> fade in of the highlight. (the default duration is 500ms)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/panel/RRDChart.js | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-28 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 13:15 [pve-devel] [PATCH widget-toolkit] panel/RRDChart: fix animation settings for highlight/marker Dominik Csapak
2021-05-28 8:43 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox