From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH manager/network v2 0/2] Improve FRR reloading logic
Date: Tue, 5 Aug 2025 10:36:04 +0200 [thread overview]
Message-ID: <a23e7d3e-cb0b-4ece-9824-5843c67a1470@proxmox.com> (raw)
In-Reply-To: <20250805083504.55378-1-s.hanreich@proxmox.com>
https://lore.proxmox.com/pve-devel/20250805083504.55378-1-s.hanreich@proxmox.com/T/#t
On 8/5/25 10:34 AM, Stefan Hanreich wrote:
> Follow-up to the stop gap fix in [1].
>
> This should handle all cases that we need to consider:
>
> * Do not overwrite existing FRR configurations, unless we need to generate our
> own FRR configuration.
>
> * Do not trigger a FRR enable when reloading the host configuration, even though
> there is no FRR configuration.
>
> * Overwrite the FRR configuration with an empty configuration if all SDN
> entities using FRR got deleted.
>
> * Regenerate the FRR configuration when the host network configuration changes,
> since this might affect the generated FRR configuration.
>
> Changes from v1:
> * fix typo and improve wording of comments
>
>
> [1] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=6c5295a1cdb6ec872ddf997cae030817dffff106
>
> pve-manager:
>
> Stefan Hanreich (1):
> network: improve reloading logic
>
> PVE/API2/Network.pm | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>
> pve-network:
>
> Stefan Hanreich (1):
> sdn: api: always send regenerate-frr parameter
>
> src/PVE/API2/Network/SDN.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> Summary over all repositories:
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-05 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 8:35 [pve-devel] " Stefan Hanreich
2025-08-05 8:35 ` [pve-devel] [PATCH pve-manager v2 1/1] network: improve " Stefan Hanreich
2025-08-05 8:35 ` [pve-devel] [PATCH pve-network v2 1/1] sdn: api: always send regenerate-frr parameter Stefan Hanreich
2025-08-05 8:36 ` Stefan Hanreich [this message]
2025-08-05 8:49 ` [pve-devel] superseded: [PATCH manager/network v2 0/2] Improve FRR reloading logic Stefan Hanreich
2025-08-05 9:22 ` [pve-devel] " Gabriel Goller
2025-08-05 9:43 ` Hannes Duerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a23e7d3e-cb0b-4ece-9824-5843c67a1470@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox