From: Fiona Ebner <f.ebner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES manager 0/2] lvm config: check that --clear-needs-check-flag is set if there is a thin_check_options override
Date: Fri, 8 Aug 2025 16:23:25 +0200 [thread overview]
Message-ID: <a1c0b01d-eb73-4fd1-b70f-b150612b012f@proxmox.com> (raw)
In-Reply-To: <1754662620.dr8couq0mf.astroid@yuna.none>
Am 08.08.25 um 4:19 PM schrieb Fabian Grünbichler:
> On August 8, 2025 4:03 pm, Fiona Ebner wrote:
>> Quoting the commit message from [0] verbatim:
>>
>>> thin_check v1.0.x reveals data block ref count issue that is not being
>>> detected by previous versions, which blocks the pool from activation if
>>> there are any leaked blocks. To reduce potential user complaints on
>>> inactive pools after upgrading and also maintain backward compatibility
>>> between LVM and older thin_check, we decided to adopt the 'auto-repair'
>>> functionality in the --clear-needs-check-flag option, rather than
>>> passing --auto-repair from lvm.conf.
>>
>> Unfortunately, there was already a user report without the override
>> [1], so this might not be the only issue. It's still worth warning
>> users about this though.
>>
>> NOTE: For stable-8 the version check in d/postinst needs to be adapted
>> or maybe we want to run the check always there?
>
> I don't think we need to run it there at all, do we? the problematic
> behaviour only comes with trixie's version of thin_check AFAIU?
Yes.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-08 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 14:03 Fiona Ebner
2025-08-08 14:03 ` [pve-devel] [PATCH manager 1/2] 8 to 9: " Fiona Ebner
2025-08-08 14:03 ` [pve-devel] [PATCH manager 2/2] d/postinst: " Fiona Ebner
2025-08-08 14:19 ` [pve-devel] [PATCH-SERIES manager 0/2] " Fabian Grünbichler
2025-08-08 14:23 ` Fiona Ebner [this message]
2025-08-08 14:19 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1c0b01d-eb73-4fd1-b70f-b150612b012f@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox