From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager 1/1] api: network: default to not regenerating the frr configuration
Date: Mon, 4 Aug 2025 16:13:04 +0200 [thread overview]
Message-ID: <a1950242-a8bf-4bb9-b2a6-add3984bc61b@proxmox.com> (raw)
In-Reply-To: <0900512d-f61f-4c5d-a5f9-84dc18eb2243@proxmox.com>
On 8/4/25 4:10 PM, Stefan Hanreich wrote:
> On 8/4/25 4:07 PM, Thomas Lamprecht wrote:
>> Am 04.08.25 um 15:46 schrieb Stefan Hanreich:
>>> Default to not regenerating the FRR configuration, unless explicitly
>>> requested. Otherwise applying the host network configuration would
>>> reload and enable the FRR service. Invert the boolean from skip to
>>> regenerate, since the logic is less convoluted this way.
>>
>>
>> and casually break API and reloading SDN during the upgrade, while
>> triggering such updates might be not the best idea to do in the first
>> place it would be at least good to call it out here.
>>
>> FWIW, if we'd walk the full mile here we probably would keep the old
>> param as fallback and check the node version from the pmxcs in memory
>> kv store in pve-network to determine what param to send to the other
>> nodes.
>>
>> That said, I can live with skip doing that, it is a major release
>> after all. Just ensure you have upgrades on your mind or, if you had,
>> add a note for that next time.
>
> The parameter has been introduced in PVE 9 with the SDN fabrics, so it
> should be fine to change this. Sorry, I should've at least mentioned it.
Ah sorry, I misunderstood - in PVE 8 we actually did always execute
generate_controller_config..
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-04 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 13:47 [pve-devel] [PATCH manager/network 0/2] do not apply FRR configuration when reloading host network configuration Stefan Hanreich
2025-08-04 13:47 ` [pve-devel] [PATCH pve-manager 1/1] api: network: default to not regenerating the frr configuration Stefan Hanreich
2025-08-04 14:07 ` Thomas Lamprecht
2025-08-04 14:11 ` Stefan Hanreich
2025-08-04 14:13 ` Stefan Hanreich [this message]
2025-08-04 13:47 ` [pve-devel] [PATCH pve-network 1/1] sdn: api: rename parameter from skip-frr to regenerate-frr Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1950242-a8bf-4bb9-b2a6-add3984bc61b@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox