public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v4 1/2] api: ceph: add applications of each pool to the lspools endpoint
Date: Tue, 25 Oct 2022 10:36:33 +0200	[thread overview]
Message-ID: <a0b0f0a7-affe-276e-967a-eb223c1c80af@proxmox.com> (raw)
In-Reply-To: <20221025081046.93094-1-s.sterz@proxmox.com>

works well and now also hides the ceph fs pools, further reducing the chances to 
build weird constellations :)

for the series:

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On 10/25/22 10:10, Stefan Sterz wrote:
> since ceph luminous (ceph 12) pools need to be associated with at
> least one applicaton. expose this information here too so that clients
> of this endpoint can use it.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> v3: add an api viewer entry for the applications object.
> v4: re-use the 'osd dump' command's result instead of issueing another
>      command.
> 
> thanks @ alwin antreich for pointing out that pools have applications!
> 
>   PVE/API2/Ceph/Pools.pm | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/PVE/API2/Ceph/Pools.pm b/PVE/API2/Ceph/Pools.pm
> index 6c05250e..fce56787 100644
> --- a/PVE/API2/Ceph/Pools.pm
> +++ b/PVE/API2/Ceph/Pools.pm
> @@ -125,6 +125,11 @@ __PACKAGE__->register_method ({
>   		    title => 'Autoscale Status',
>   		    optional => 1,
>   		},
> +		application_metadata => {
> +		    type => 'object',
> +		    title => 'Associated Applications',
> +		    optional => 1,
> +		},
>   	    },
>   	},
>   	links => [ { rel => 'child', href => "{pool_name}" } ],
> @@ -162,6 +167,7 @@ __PACKAGE__->register_method ({
>   	    'pg_num',
>   	    'crush_rule',
>   	    'pg_autoscale_mode',
> +	    'application_metadata',
>   	];
>   
>   	# pg_autoscaler module is not enabled in Nautilus




  parent reply	other threads:[~2022-10-25  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  8:10 Stefan Sterz
2022-10-25  8:10 ` [pve-devel] [PATCH manager v4 2/2] ui: only allow rbd pools to be added as rbd storage Stefan Sterz
2022-10-25  8:36 ` Aaron Lauterer [this message]
2022-11-16 19:25 ` [pve-devel] applied-series: [PATCH manager v4 1/2] api: ceph: add applications of each pool to the lspools endpoint Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0b0f0a7-affe-276e-967a-eb223c1c80af@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal