From: Fabian Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 storage 1/5] postinst: move cifs credential files into subdirectory upon update
Date: Thu, 17 Jun 2021 10:09:28 +0200 [thread overview]
Message-ID: <a039a665-8195-ded6-968a-feabb6e57ef1@proxmox.com> (raw)
In-Reply-To: <422e61d2-821c-d58b-9bcd-2c270c64c88c@proxmox.com>
Am 16.06.21 um 15:11 schrieb Thomas Lamprecht:
> On 16.06.21 09:26, Fabian Ebner wrote:
>> +case "$1" in
>> + configure)
>> + if test -n "$2"; then
>> +
>> + # TODO: remove once PVE 8.0 is released
>> + if dpkg --compare-versions "$2" 'lt' '7.0-3'; then
>> + for file in /etc/pve/priv/*.cred; do
>> + if [ -f "$file" ]; then
>> + mkdir -p "/etc/pve/priv/storage"
>> + echo "Info: found CIFS credentials using old path: $file" >&2
>> + base=$(basename --suffix=".cred" "$file")
>> + target="/etc/pve/priv/storage/$base.pw"
>> + if [ -f "$target" ]; then
>> + echo "Warning: not renaming $file, because $target already exists!" >&2
>
> can we diff in this case and remove the old one if the files are identical?
>
Sure, I'll send a follow-up.
>> + else
>> + echo "Info: renaming $file to $target" >&2
>> + mv "$file" "$target"
>> + fi
>> + fi
>> + done
>> + fi
>> + fi
>> + ;;
>> +
>> +esac
>> +
>> +exit 0
>>
>
next prev parent reply other threads:[~2021-06-17 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 7:26 [pve-devel] [PATCH-SERIES v2 manager/storage] Some breaking API changes/cleanups Fabian Ebner
2021-06-16 7:26 ` [pve-devel] [PATCH v2 manager 1/3] pve6to7: add checks for backup retention options Fabian Ebner
2021-06-16 7:26 ` [pve-devel] [PATCH v2 manager 2/3] pve6to7: add check for CIFS credentials Fabian Ebner
2021-06-16 7:26 ` [pve-devel] [PATCH v2 manager 3/3] ui: storage: update hint about prune-backups default Fabian Ebner
2021-06-16 7:26 ` [pve-devel] [PATCH v2 storage 1/5] postinst: move cifs credential files into subdirectory upon update Fabian Ebner
2021-06-16 13:11 ` Thomas Lamprecht
2021-06-17 8:09 ` Fabian Ebner [this message]
2021-06-16 7:26 ` [pve-devel] [PATCH v2 storage 2/5] config: mention that maxfiles is deprecated Fabian Ebner
2021-06-16 7:26 ` [pve-devel] [PATCH v2 storage 3/5] config: add backup content type to default local storage Fabian Ebner
2021-06-16 7:26 ` [pve-devel] [PATCH v2 storage 4/5] cephfs: revert safe-guard check for Luminous Fabian Ebner
2021-06-16 7:27 ` [pve-devel] [RFC v2 storage 5/5] cephfs: update reminder for systemd_netmount removal Fabian Ebner
2021-06-16 11:51 ` [pve-devel] applied-series: [PATCH-SERIES v2 manager/storage] Some breaking API changes/cleanups Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a039a665-8195-ded6-968a-feabb6e57ef1@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox