[pve-devel] [PATCH pve-cluster] cluster config: mark qdevice end point as protected

[pve-devel] [PATCH pve-cluster] cluster config: mark qdevice end point as protected

[Stefan Sterz]

this allows the end point to retrieve data from the qdevice properly
by leveraging pve-daemon. fixes an issue where the api would return an
empty object.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 data/PVE/API2/ClusterConfig.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/PVE/API2/ClusterConfig.pm b/data/PVE/API2/ClusterConfig.pm
index 5a6a1ac..e7efe37 100644
--- a/data/PVE/API2/ClusterConfig.pm
+++ b/data/PVE/API2/ClusterConfig.pm
@@ -661,6 +661,7 @@ __PACKAGE__->register_method ({
     name => 'status',
     path => 'qdevice',
     method => 'GET',
+    protected => 1,
     description => 'Get QDevice status',
     permissions => {
 	check => ['perm', '/', [ 'Sys.Audit' ]],
-- 
2.30.2

Re: [pve-devel] [PATCH pve-cluster] cluster config: mark qdevice end point as protected

[Oguz Bektas]

thanks for picking this up :)

tested on my cluster with qdevice and it solves the issue reported in
forum [0]

Tested-by: Oguz Bektas <o.bektas@proxmox.com>

[0]:
https://forum.proxmox.com/threads/109308/

On Wed, May 11, 2022 at 11:27:07AM +0200, Stefan Sterz wrote:
> this allows the end point to retrieve data from the qdevice properly
> by leveraging pve-daemon. fixes an issue where the api would return an
> empty object.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  data/PVE/API2/ClusterConfig.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/data/PVE/API2/ClusterConfig.pm b/data/PVE/API2/ClusterConfig.pm
> index 5a6a1ac..e7efe37 100644
> --- a/data/PVE/API2/ClusterConfig.pm
> +++ b/data/PVE/API2/ClusterConfig.pm
> @@ -661,6 +661,7 @@ __PACKAGE__->register_method ({
>      name => 'status',
>      path => 'qdevice',
>      method => 'GET',
> +    protected => 1,
>      description => 'Get QDevice status',
>      permissions => {
>  	check => ['perm', '/', [ 'Sys.Audit' ]],
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 

[pve-devel] applied: [PATCH pve-cluster] cluster config: mark qdevice end point as protected

[Thomas Lamprecht]

Am 5/11/22 um 11:27 schrieb Stefan Sterz:
> this allows the end point to retrieve data from the qdevice properly
> by leveraging pve-daemon. fixes an issue where the api would return an
> empty object.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  data/PVE/API2/ClusterConfig.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, with Oğuz T-b tag and some more info about the actual problem in
the commit message, thanks!