From: Oguz Bektas <o.bektas@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-cluster] cluster config: mark qdevice end point as protected
Date: Wed, 11 May 2022 11:28:56 +0200 [thread overview]
Message-ID: <YnuB2CRQ11RpkyPA@gaia> (raw)
In-Reply-To: <20220511092707.155595-1-s.sterz@proxmox.com>
thanks for picking this up :)
tested on my cluster with qdevice and it solves the issue reported in
forum [0]
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
[0]:
https://forum.proxmox.com/threads/109308/
On Wed, May 11, 2022 at 11:27:07AM +0200, Stefan Sterz wrote:
> this allows the end point to retrieve data from the qdevice properly
> by leveraging pve-daemon. fixes an issue where the api would return an
> empty object.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> data/PVE/API2/ClusterConfig.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/data/PVE/API2/ClusterConfig.pm b/data/PVE/API2/ClusterConfig.pm
> index 5a6a1ac..e7efe37 100644
> --- a/data/PVE/API2/ClusterConfig.pm
> +++ b/data/PVE/API2/ClusterConfig.pm
> @@ -661,6 +661,7 @@ __PACKAGE__->register_method ({
> name => 'status',
> path => 'qdevice',
> method => 'GET',
> + protected => 1,
> description => 'Get QDevice status',
> permissions => {
> check => ['perm', '/', [ 'Sys.Audit' ]],
> --
> 2.30.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2022-05-11 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 9:27 Stefan Sterz
2022-05-11 9:28 ` Oguz Bektas [this message]
2022-05-11 10:14 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnuB2CRQ11RpkyPA@gaia \
--to=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox